Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-05-02 Thread Neil Conway
> On April 29, 2016, 9:29 a.m., Alexander Rukletsov wrote: > > It would be great to implement `CHECK_NREADY`, `CHECK_NDISCARDED`, then we > > could have replaced `CHECK(!candidacy.isDiscarded());` for consistency. Do > > you want to do it here or follow up with another patch? > > Neil Conway

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-05-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46827/#review131287 --- Ship it! Ship It! - Alexander Rukletsov On April 29, 2016,

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-05-02 Thread Alexander Rukletsov
> On April 29, 2016, 9:29 a.m., Alexander Rukletsov wrote: > > It would be great to implement `CHECK_NREADY`, `CHECK_NDISCARDED`, then we > > could have replaced `CHECK(!candidacy.isDiscarded());` for consistency. Do > > you want to do it here or follow up with another patch? > > Neil Conway

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46827/#review131167 --- Patch looks great! Reviews applied: [46827] Passed command:

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-04-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46827/ --- (Updated April 29, 2016, 2:08 p.m.) Review request for mesos and Alexander

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46827/#review131084 --- Patch looks great! Reviews applied: [46826, 46827] Passed

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-04-29 Thread Neil Conway
> On April 29, 2016, 9:29 a.m., Alexander Rukletsov wrote: > > It would be great to implement `CHECK_NREADY`, `CHECK_NDISCARDED`, then we > > could have replaced `CHECK(!candidacy.isDiscarded());` for consistency. Do > > you want to do it here or follow up with another patch? Seems reasonable

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-04-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46827/#review131066 --- It would be great to implement `CHECK_NREADY`,