Re: Review Request 46942: Fixed docker volume isolator container mount target.

2016-05-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46942/#review131550
---



Patch looks great!

Reviews applied: [46942]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 3, 2016, 7:50 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46942/
> ---
> 
> (Updated May 3, 2016, 7:50 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed docker volume isolator container mount target.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f 
> 
> Diff: https://reviews.apache.org/r/46942/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 46942: Fixed docker volume isolator container mount target.

2016-05-03 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46942/
---

(Updated May 3, 2016, 12:50 p.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
Chen.


Repository: mesos


Description
---

Fixed docker volume isolator container mount target.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f 

Diff: https://reviews.apache.org/r/46942/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 46942: Fixed docker volume isolator container mount target.

2016-05-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46942/#review131539
---



Patch looks great!

Reviews applied: [46942]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 3, 2016, 6:10 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46942/
> ---
> 
> (Updated May 3, 2016, 6:10 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed docker volume isolator container mount target.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f 
> 
> Diff: https://reviews.apache.org/r/46942/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 46942: Fixed docker volume isolator container mount target.

2016-05-03 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46942/#review131536
---


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 334)


Please use path::absolute here.



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 367)


Can you copy the NOTE as well?


- Jie Yu


On May 3, 2016, 6:10 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46942/
> ---
> 
> (Updated May 3, 2016, 6:10 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed docker volume isolator container mount target.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f 
> 
> Diff: https://reviews.apache.org/r/46942/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>