Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2017-03-01 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/#review167318 --- Closing this review due to inactivity. Please see our

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-15 Thread Chen Nan Li
> On 五月 13, 2016, 2:58 p.m., haosdent huang wrote: > > src/webui/master/static/directives/tableHeader.html, line 3 > > > > > > Seems `id` here is unnecessary, I think could remove it. > > > > ``` > >

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/#review133119 --- src/webui/master/static/directives/tableHeader.html (line 3)

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/#review132022 --- Ship it! Ship It! - Neil Conway On May 6, 2016, 8:57 a.m.,

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-06 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/ --- (Updated 五月 6, 2016, 8:57 a.m.) Review request for mesos, Zhiwei Chen and

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-05 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/ --- (Updated 五月 6, 2016, 5:32 a.m.) Review request for mesos, Zhiwei Chen and

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-04 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/ --- (Updated 五月 5, 2016, 1:19 a.m.) Review request for mesos, Zhiwei Chen and

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/#review131622 --- Patch looks great! Reviews applied: [46954] Passed command: