Re: Review Request 46975: Add title and heading in Mesos Log Page.

2017-03-01 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46975/#review167300
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On May 8, 2016, 11:52 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46975/
> ---
> 
> (Updated May 8, 2016, 11:52 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add title and heading in Mesos Log Page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/pailer.html 
> 19e0981143bd7e8372b49f4f036867e9dd05727a 
> 
> 
> Diff: https://reviews.apache.org/r/46975/diff/3/
> 
> 
> Testing
> ---
> 
> Mesos log page should have a title. for details: 
> https://www.w3.org/TR/WCAG20-TECHS/H25
> 
> And Should give a heading to tell screen reader that the content in the page 
> is "Mesos log"
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46975: Add title and heading in Mesos Log Page.

2016-05-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46975/#review132175
---



Patch looks great!

Reviews applied: [46975]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 8, 2016, 11:52 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46975/
> ---
> 
> (Updated May 8, 2016, 11:52 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add title and heading in Mesos Log Page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/pailer.html 
> 19e0981143bd7e8372b49f4f036867e9dd05727a 
> 
> Diff: https://reviews.apache.org/r/46975/diff/
> 
> 
> Testing
> ---
> 
> Mesos log page should have a title. for details: 
> https://www.w3.org/TR/WCAG20-TECHS/H25
> 
> And Should give a heading to tell screen reader that the content in the page 
> is "Mesos log"
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46975: Add title and heading in Mesos Log Page.

2016-05-08 Thread Chen Nan Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46975/
---

(Updated May 8, 2016, 11:52 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Changes
---

change "Mesos Log" to "Mesos Log Pailer"


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Add title and heading in Mesos Log Page.


Diffs (updated)
-

  src/webui/master/static/pailer.html 19e0981143bd7e8372b49f4f036867e9dd05727a 

Diff: https://reviews.apache.org/r/46975/diff/


Testing
---

Mesos log page should have a title. for details: 
https://www.w3.org/TR/WCAG20-TECHS/H25

And Should give a heading to tell screen reader that the content in the page is 
"Mesos log"


Thanks,

Chen Nan Li

Re: Review Request 46975: Add title and heading in Mesos Log Page.

2016-05-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46975/#review132051
---


Fix it, then Ship it!




Ship It!


src/webui/master/static/pailer.html (line 5)


Seems use `Mesos Log Pailer` would be better here.


- haosdent huang


On May 6, 2016, 1:30 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46975/
> ---
> 
> (Updated May 6, 2016, 1:30 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add title and heading in Mesos Log Page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/pailer.html 
> 19e0981143bd7e8372b49f4f036867e9dd05727a 
> 
> Diff: https://reviews.apache.org/r/46975/diff/
> 
> 
> Testing
> ---
> 
> Mesos log page should have a title. for details: 
> https://www.w3.org/TR/WCAG20-TECHS/H25
> 
> And Should give a heading to tell screen reader that the content in the page 
> is "Mesos log"
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46975: Add title and heading in Mesos Log Page.

2016-05-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46975/#review131985
---



Patch looks great!

Reviews applied: [46975]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 1:30 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46975/
> ---
> 
> (Updated May 6, 2016, 1:30 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add title and heading in Mesos Log Page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/pailer.html 
> 19e0981143bd7e8372b49f4f036867e9dd05727a 
> 
> Diff: https://reviews.apache.org/r/46975/diff/
> 
> 
> Testing
> ---
> 
> Mesos log page should have a title. for details: 
> https://www.w3.org/TR/WCAG20-TECHS/H25
> 
> And Should give a heading to tell screen reader that the content in the page 
> is "Mesos log"
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46975: Add title and heading in Mesos Log Page.

2016-05-05 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46975/#review131882
---




src/webui/master/static/pailer.html (line 24)


Indent is not correct here.


- haosdent huang


On May 5, 2016, 2:55 p.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46975/
> ---
> 
> (Updated May 5, 2016, 2:55 p.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add title and heading in Mesos Log Page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/pailer.html 
> 19e0981143bd7e8372b49f4f036867e9dd05727a 
> 
> Diff: https://reviews.apache.org/r/46975/diff/
> 
> 
> Testing
> ---
> 
> Mesos log page should have a title. for details: 
> https://www.w3.org/TR/WCAG20-TECHS/H25
> 
> And Should give a heading to tell screen reader that the content in the page 
> is "Mesos log"
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46975: Add title and heading in Mesos Log Page.

2016-05-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46975/#review131791
---



Patch looks great!

Reviews applied: [46975]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 5, 2016, 1:10 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46975/
> ---
> 
> (Updated May 5, 2016, 1:10 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add title and heading in Mesos Log Page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/pailer.html 
> 19e0981143bd7e8372b49f4f036867e9dd05727a 
> 
> Diff: https://reviews.apache.org/r/46975/diff/
> 
> 
> Testing
> ---
> 
> Mesos log page should have a title for details: 
> https://www.w3.org/TR/WCAG20-TECHS/H25
> 
> And Should give a heading to tell screen reader that content in the page is 
> Mesos log
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>