Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

2016-05-06 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46989/
---

(Updated May 6, 2016, 9:20 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds the handling of authorization calls
for libprocess-level HTTP endpoints into the
`ProcessBase::visit` method. The authorization results
are sequenced to assure that operations are execute in
the same order in which they are received.


Diffs
-

  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/46989/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

2016-05-06 Thread Greg Mann 


> On May 6, 2016, 6:01 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 3346-3355
> > 
> >
> > Can we simplify the logic a bit here and add some explanation?

This review was merged into https://reviews.apache.org/r/46866/


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46989/#review132085
---


On May 5, 2016, 8:15 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46989/
> ---
> 
> (Updated May 5, 2016, 8:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds the handling of authorization calls
> for libprocess-level HTTP endpoints into the
> `ProcessBase::visit` method. The authorization results
> are sequenced to assure that operations are execute in
> the same order in which they are received.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/46989/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

2016-05-06 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46989/#review132085
---




3rdparty/libprocess/src/process.cpp (lines 3299 - 3308)


Can we simplify the logic a bit here and add some explanation?



3rdparty/libprocess/src/process.cpp (lines 3315 - 3318)


Simplify this too so that callback_path is set iff there is a callback for 
the requested URL.


- Kapil Arya


On May 5, 2016, 4:15 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46989/
> ---
> 
> (Updated May 5, 2016, 4:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds the handling of authorization calls
> for libprocess-level HTTP endpoints into the
> `ProcessBase::visit` method. The authorization results
> are sequenced to assure that operations are execute in
> the same order in which they are received.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/46989/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

2016-05-05 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46989/
---

(Updated May 5, 2016, 8:15 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds the handling of authorization calls
for libprocess-level HTTP endpoints into the
`ProcessBase::visit` method. The authorization results
are sequenced to assure that operations are execute in
the same order in which they are received.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/46989/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

2016-05-05 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46989/
---

(Updated May 5, 2016, 6:58 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds the handling of authorization calls
for libprocess-level HTTP endpoints into the
`ProcessBase::visit` method. The authorization results
are sequenced to assure that operations are execute in
the same order in which they are received.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/46989/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

2016-05-05 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46989/
---

(Updated May 5, 2016, 1:46 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Changes
---

Rebase.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds the handling of authorization calls
for libprocess-level HTTP endpoints into the
`ProcessBase::visit` method. The authorization results
are sequenced to assure that operations are execute in
the same order in which they are received.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/46989/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

2016-05-04 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46989/
---

(Updated May 4, 2016, 9:21 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Changes
---

Changed `authorization_callbacks` to a pointer.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds the handling of authorization calls
for libprocess-level HTTP endpoints into the
`ProcessBase::visit` method. The authorization results
are sequenced to assure that operations are execute in
the same order in which they are received.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/46989/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann