Re: Review Request 47032: Fixed HttpCachedConcurrent flakiness in slow machine.

2017-03-01 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47032/#review167299
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On May 5, 2016, 5:54 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47032/
> ---
> 
> (Updated May 5, 2016, 5:54 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3235
> https://issues.apache.org/jira/browse/MESOS-3235
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> FetcherCacheHttpTest.HttpCachedConcurrent launch 5 concurrent tasks at
> the same time. This requires more time in slow machine. We increased
> the waiting time to avoid the flakiness.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp ba7d3f84ee54d982d7dfe0eeb9c67c1a68f9cf40 
> 
> 
> Diff: https://reviews.apache.org/r/47032/diff/1/
> 
> 
> Testing
> ---
> 
> Test repeatly in my slow vm more than 700 cycles.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 47032: Fixed HttpCachedConcurrent flakiness in slow machine.

2016-05-05 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47032/#review131958
---



Patch looks great!

Reviews applied: [47032]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 5, 2016, 5:54 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47032/
> ---
> 
> (Updated May 5, 2016, 5:54 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3235
> https://issues.apache.org/jira/browse/MESOS-3235
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> FetcherCacheHttpTest.HttpCachedConcurrent launch 5 concurrent tasks at
> the same time. This requires more time in slow machine. We increased
> the waiting time to avoid the flakiness.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp ba7d3f84ee54d982d7dfe0eeb9c67c1a68f9cf40 
> 
> Diff: https://reviews.apache.org/r/47032/diff/
> 
> 
> Testing
> ---
> 
> Test repeatly in my slow vm more than 700 cycles.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>