Re: Review Request 47054: Windows: Removed `Zookeeper's` NTDDI_VERSION.

2016-05-12 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47054/
---

(Updated May 12, 2016, 10:22 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5373
https://issues.apache.org/jira/browse/MESOS-5373


Repository: mesos


Description
---

Windows: Removed `Zookeeper's` NTDDI_VERSION.


Diffs (updated)
-

  3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 

Diff: https://reviews.apache.org/r/47054/diff/


Testing
---

OSX: make
Windows: msbuild


Thanks,

Daniel Pravat

Re: Review Request 47054: Windows: Removed `Zookeeper's` NTDDI_VERSION.

2016-05-10 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47054/
---

(Updated May 11, 2016, 6:07 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: Removed `Zookeeper's` NTDDI_VERSION.


Diffs (updated)
-

  3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 

Diff: https://reviews.apache.org/r/47054/diff/


Testing
---

OSX: make
Windows: msbuild


Thanks,

Daniel Pravat

Re: Review Request 47054: Windows: Removed `Zookeeper's` NTDDI_VERSION.

2016-05-10 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47054/#review132479
---


Ship it!




I strongly agree with Joris's comment here, so I do ask we please add a comment 
before shipping.

- Alex Clemmer


On May 6, 2016, 4:17 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47054/
> ---
> 
> (Updated May 6, 2016, 4:17 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Removed `Zookeeper's` NTDDI_VERSION.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 
> 
> Diff: https://reviews.apache.org/r/47054/diff/
> 
> 
> Testing
> ---
> 
> OSX: make
> Windows: msbuild
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 47054: Windows: Removed `Zookeeper's` NTDDI_VERSION.

2016-05-10 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47054/#review132455
---


Fix it, then Ship it!





3rdparty/zookeeper-06d3f3f.patch (lines 142 - 150)


Can we add a comment here as to what we are doing, and why?
This will make it easier for someone to update this file in the future.


- Joris Van Remoortere


On May 6, 2016, 4:17 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47054/
> ---
> 
> (Updated May 6, 2016, 4:17 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Removed `Zookeeper's` NTDDI_VERSION.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 
> 
> Diff: https://reviews.apache.org/r/47054/diff/
> 
> 
> Testing
> ---
> 
> OSX: make
> Windows: msbuild
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 47054: Windows: Removed `Zookeeper's` NTDDI_VERSION.

2016-05-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47054/#review132007
---



Patch looks great!

Reviews applied: [47052, 47053, 47054]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 4:17 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47054/
> ---
> 
> (Updated May 6, 2016, 4:17 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Removed `Zookeeper's` NTDDI_VERSION.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 
> 
> Diff: https://reviews.apache.org/r/47054/diff/
> 
> 
> Testing
> ---
> 
> OSX: make
> Windows: msbuild
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>