Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-16 Thread Abhishek Dasgupta
> On May 13, 2016, 2:50 p.m., Alexander Rukletsov wrote: > > src/slave/slave.cpp, line 766 > > > > > > Uups, is it intended? If yes, please do it in a separate patch. Thought again and discarded logging. - Abhishe

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-16 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/ --- (Updated May 16, 2016, 7:37 a.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/#review133120 --- Ship it! Ship It! - Till Toenshoff On May 13, 2016, 9:50 a.m

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-13 Thread Till Toenshoff
> On May 13, 2016, 2:59 p.m., Till Toenshoff wrote: > > Ship It! Minus the "debugging artefact?" Alex noted. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/#review133120 ---

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/#review133114 --- Fix it, then Ship it! src/slave/slave.cpp (line 766)

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-13 Thread Abhishek Dasgupta
> On May 12, 2016, 8:51 p.m., Alexander Rukletsov wrote: > > Could you please update `Slave::Http::CONTAINERS_HELP()` as well? Yeah, updated. Added another RR https://reviews.apache.org/r/47340/ for the updated doc for /containers endpoint generated by running support/generate-endpoint.sh. -

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-13 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/ --- (Updated May 13, 2016, 9:35 a.m.) Review request for mesos, Adam B, Greg Mann,

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/#review132974 --- Could you please update `Slave::Http::CONTAINERS_HELP()` as well?