Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-26 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/#review134940
---


Ship it!




Ship It!

- Michael Park


On May 26, 2016, 4:43 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47069/
> ---
> 
> (Updated May 26, 2016, 4:43 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The LocalAuthorizer might use the OS \`user\` for
> authorization of tasks, so we add it to the \`Task\` protobuf
> message. Note that the master stores \`Task\` (as opposed
> to \`TaskInfo\`) for running and completed tasks.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto f666535bcaf8ec263eada7e0cf925d8eb3836ba8 
>   src/common/http.cpp ad6a4b44af3ec847a3a6c0839a88fba18cda5011 
>   src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
>   src/common/type_utils.cpp 037c4336276258d671d0b1bf66cdab50b5bf9fb8 
>   src/tests/common/http_tests.cpp 300f7cc21239b7d8727f7f0f02963f1af0dc80d7 
> 
> Diff: https://reviews.apache.org/r/47069/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-25 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/
---

(Updated May 26, 2016, 4:43 a.m.)


Review request for mesos, Adam B, Alexander Rojas, and Michael Park.


Repository: mesos


Description
---

The LocalAuthorizer might use the OS \`user\` for
authorization of tasks, so we add it to the \`Task\` protobuf
message. Note that the master stores \`Task\` (as opposed
to \`TaskInfo\`) for running and completed tasks.


Diffs (updated)
-

  include/mesos/mesos.proto f666535bcaf8ec263eada7e0cf925d8eb3836ba8 
  src/common/http.cpp ad6a4b44af3ec847a3a6c0839a88fba18cda5011 
  src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
  src/common/type_utils.cpp 037c4336276258d671d0b1bf66cdab50b5bf9fb8 
  src/tests/common/http_tests.cpp 300f7cc21239b7d8727f7f0f02963f1af0dc80d7 

Diff: https://reviews.apache.org/r/47069/diff/


Testing
---

tested entire chain.


Thanks,

Joerg Schad

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-24 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/
---

(Updated May 24, 2016, 4:06 p.m.)


Review request for mesos, Adam B, Alexander Rojas, and Michael Park.


Changes
---

Adressed review


Repository: mesos


Description
---

The LocalAuthorizer might use the OS \`user\` for
authorization of tasks, so we add it to the \`Task\` protobuf
message. Note that the master stores \`Task\` (as opposed
to \`TaskInfo\`) for running and completed tasks.


Diffs (updated)
-

  include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
  src/common/http.cpp ad6a4b44af3ec847a3a6c0839a88fba18cda5011 
  src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
  src/common/type_utils.cpp 037c4336276258d671d0b1bf66cdab50b5bf9fb8 
  src/tests/common/http_tests.cpp 300f7cc21239b7d8727f7f0f02963f1af0dc80d7 

Diff: https://reviews.apache.org/r/47069/diff/


Testing
---

tested entire chain.


Thanks,

Joerg Schad

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-21 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/#review134250
---




src/common/http.cpp (lines 288 - 290)


This has inconsistent behavior with `void json(JSON::ObjectWriter* writer, 
const Task& task);`. I think we want to the behavior in `json` and leave `user` 
out if it's not set?


- Michael Park


On May 21, 2016, 8:32 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47069/
> ---
> 
> (Updated May 21, 2016, 8:32 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The LocalAuthorizer might use the OS \`user\` for
> authorization of tasks, so we add it to the \`Task\` protobuf
> message. Note that the master stores \`Task\` (as opposed
> to \`TaskInfo\`) for running and completed tasks.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
>   src/common/http.cpp ad6a4b44af3ec847a3a6c0839a88fba18cda5011 
>   src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
>   src/common/type_utils.cpp 037c4336276258d671d0b1bf66cdab50b5bf9fb8 
>   src/tests/common/http_tests.cpp 300f7cc21239b7d8727f7f0f02963f1af0dc80d7 
> 
> Diff: https://reviews.apache.org/r/47069/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-21 Thread Joerg Schad 


> On May 21, 2016, 5:49 a.m., Michael Park wrote:
> > Do we not need to update other parts such as `bool operator==(const Task&, 
> > const Task&);`, and exposing the `user` field in `/state`, etc?

Nice catch, added.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/#review134233
---


On May 21, 2016, 8:32 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47069/
> ---
> 
> (Updated May 21, 2016, 8:32 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The LocalAuthorizer might use the OS \`user\` for
> authorization of tasks, so we add it to the \`Task\` protobuf
> message. Note that the master stores \`Task\` (as opposed
> to \`TaskInfo\`) for running and completed tasks.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
>   src/common/http.cpp ad6a4b44af3ec847a3a6c0839a88fba18cda5011 
>   src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
>   src/common/type_utils.cpp 037c4336276258d671d0b1bf66cdab50b5bf9fb8 
>   src/tests/common/http_tests.cpp 300f7cc21239b7d8727f7f0f02963f1af0dc80d7 
> 
> Diff: https://reviews.apache.org/r/47069/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-21 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/
---

(Updated May 21, 2016, 8:32 a.m.)


Review request for mesos, Adam B, Alexander Rojas, and Michael Park.


Repository: mesos


Description
---

The LocalAuthorizer might use the OS \`user\` for
authorization of tasks, so we add it to the \`Task\` protobuf
message. Note that the master stores \`Task\` (as opposed
to \`TaskInfo\`) for running and completed tasks.


Diffs (updated)
-

  include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
  src/common/http.cpp ad6a4b44af3ec847a3a6c0839a88fba18cda5011 
  src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
  src/common/type_utils.cpp 037c4336276258d671d0b1bf66cdab50b5bf9fb8 
  src/tests/common/http_tests.cpp 300f7cc21239b7d8727f7f0f02963f1af0dc80d7 

Diff: https://reviews.apache.org/r/47069/diff/


Testing
---

tested entire chain.


Thanks,

Joerg Schad

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-20 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/#review134233
---



Do we not need to update other parts such as `bool operator==(const Task&, 
const Task&);`, and exposing the `user` field in `/state`, etc?

- Michael Park


On May 17, 2016, 9:28 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47069/
> ---
> 
> (Updated May 17, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The LocalAuthorizer might use the OS \`user\` for
> authorization of tasks, so we add it to the \`Task\` protobuf
> message. Note that the master stores \`Task\` (as opposed
> to \`TaskInfo\`) for running and completed tasks.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
>   src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
> 
> Diff: https://reviews.apache.org/r/47069/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-17 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/
---

(Updated May 17, 2016, 9:28 p.m.)


Review request for mesos, Adam B, Alexander Rojas, and Michael Park.


Repository: mesos


Description (updated)
---

The LocalAuthorizer might use the OS \`user\` for
authorization of tasks, so we add it to the \`Task\` protobuf
message. Note that the master stores \`Task\` (as opposed
to \`TaskInfo\`) for running and completed tasks.


Diffs (updated)
-

  include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
  src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 

Diff: https://reviews.apache.org/r/47069/diff/


Testing
---

tested entire chain.


Thanks,

Joerg Schad

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-17 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/
---

(Updated May 17, 2016, 8:49 p.m.)


Review request for mesos, Adam B, Alexander Rojas, and Michael Park.


Repository: mesos


Description (updated)
---

The LocalAuthorizer will use the OS `user` for
authorization of tasks we add it to the `Task` protobuf
message. Note that the master stores `Task` (as opposed
to `TaskInfo`) for running and completed tasks.


Diffs
-

  src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
  src/messages/messages.proto e0f1fca92d3ea8c29c095da31653c317873a934c 

Diff: https://reviews.apache.org/r/47069/diff/


Testing (updated)
---

tested entire chain.


Thanks,

Joerg Schad

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-09 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/#review132246
---



In the description: `/protobug/protobuf/`, also, I would avoid starting the 
description with _As…_


src/common/protobuf_utils.cpp (line 185)


Not yours but I die a little every time I see a variable named with one 
letter.


- Alexander Rojas


On May 6, 2016, 10:33 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47069/
> ---
> 
> (Updated May 6, 2016, 10:33 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As the LocalAuthorizer will use the OS `user` for
> authorization of tasks we add it to the `Task` protobug
> message. Note that the master stores `Task` (as opposed
> to `TaskInfo`) for running and completed tasks.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
>   src/messages/messages.proto e0f1fca92d3ea8c29c095da31653c317873a934c 
> 
> Diff: https://reviews.apache.org/r/47069/diff/
> 
> 
> Testing
> ---
> 
> tested entire check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>