Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

2016-05-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47089/#review133493 --- Patch looks great! Reviews applied: [47089] Passed command: expo

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

2016-05-16 Thread haosdent huang
> On May 13, 2016, 8:37 p.m., Benjamin Mahler wrote: > > src/tests/health_check_tests.cpp, line 1059 > > > > > > It looks like the clock needs to be paused before the task is launched? > > Otherwise we may have too

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

2016-05-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47089/ --- (Updated May 17, 2016, 2:14 a.m.) Review request for mesos, Benjamin Mahler, Ni

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

2016-05-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47089/ --- (Updated May 17, 2016, 1:33 a.m.) Review request for mesos, Benjamin Mahler, Ni

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

2016-05-16 Thread haosdent huang
> On May 13, 2016, 8:37 p.m., Benjamin Mahler wrote: > > src/tests/health_check_tests.cpp, line 1015 > > > > > > Why did this change? Yes, we need this so that we could check the stdout/stderr from console if it s

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

2016-05-13 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47089/#review133196 --- src/tests/health_check_tests.cpp (line 1015)

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

2016-05-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47089/#review132139 --- Patch looks great! Reviews applied: [47089] Passed command: expo

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

2016-05-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47089/ --- (Updated May 7, 2016, 11:46 a.m.) Review request for mesos, Ben Mahler, Niklas