Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/#review134776 --- Ship it! Ship It! - Jie Yu On May 24, 2016, 5:18 p.m.,

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/ --- (Updated May 24, 2016, 10:18 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/#review134450 --- include/mesos/docker/v1.proto (lines 53 - 56)

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-13 Thread Guangya Liu
> On 五月 12, 2016, 12:25 p.m., Guangya Liu wrote: > > include/mesos/docker/v1.proto, lines 56-57 > > > > > > Why both `optional`? I found that other `Label` definition are defining > > `key` as required but `value`

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/ --- (Updated May 13, 2016, 1:48 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-13 Thread Gilbert Song
> On May 12, 2016, 5:25 a.m., Guangya Liu wrote: > > include/mesos/docker/v1.proto, lines 56-57 > > > > > > Why both `optional`? I found that other `Label` definition are defining > > `key` as required but `value`

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/#review132879 --- include/mesos/docker/v1.proto (lines 56 - 57)

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-11 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/#review132823 --- include/mesos/docker/v1.proto (lines 53 - 54)

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/ --- (Updated May 11, 2016, 8:56 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-10 Thread Kevin Klues
> On May 11, 2016, 12:41 a.m., Kevin Klues wrote: > > include/mesos/docker/v1.proto, lines 55-60 > > > > > > I don't quite understand this comment. WHy isn't this just a repeated > > optional string? > > Gilbert

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-10 Thread Gilbert Song
> On May 10, 2016, 5:41 p.m., Kevin Klues wrote: > > include/mesos/docker/v1.proto, lines 55-60 > > > > > > I don't quite understand this comment. WHy isn't this just a repeated > > optional string? WHy isn't this