Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/#review135356 --- Ship it! Ship It! - Kapil Arya On May 25, 2016, 10:02 p.m.,

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/#review135101 --- Ship it! Ship It! - Jie Yu On May 26, 2016, 2:02 a.m.,

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

> On May 25, 2016, 6:18 p.m., Jie Yu wrote: > > src/docker/executor.hpp, line 90 > > > > > > Can this be `Option`? If I make this a `JSON::Object`, the invocation site (https://reviews.apache.org/r/47216/diff/2#1)

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/ --- (Updated May 25, 2016, 7:02 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/#review134882 --- src/docker/executor.hpp (line 89)

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/ --- (Updated May 24, 2016, 2:02 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/#review134499 --- src/docker/executor.hpp (lines 80 - 107)

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

> On May 11, 2016, 12:26 p.m., Benjamin Bannier wrote: > > src/docker/executor.hpp, line 120 > > > > > > Any reason we wouldn't use an unordered map like e.g., a stout > > `hashmap` here and as function argument

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/ --- (Updated May 11, 2016, 1:03 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/#review132731 --- src/docker/executor.hpp (line 27)