Re: Review Request 47324: Update leveldb to 1.18.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review145970 --- Closing in favor of [51053](https://reviews.apache.org/r/51053/) - Tomasz Janiszewski On Aug. 12, 2016, 4:58 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47324/ > --- > > (Updated Aug. 12, 2016, 4:58 p.m.) > > > Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent > huang. > > > Bugs: MESOS-970 > https://issues.apache.org/jira/browse/MESOS-970 > > > Repository: mesos > > > Description > --- > > Leveldb in modern version is required to support s390x. > It's also required to replace default byte-wise comparator > with varint comparator in `src/log/leveldb.cpp`. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe > 3rdparty/leveldb-1.18.patch PRE-CREATION > 3rdparty/leveldb-1.18.tar.gz PRE-CREATION > 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 > 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 > 3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 > LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a > src/python/native_common/ext_modules.py.in > 2d4a45efa224b32f80ace4542a00062c5ccb06d5 > > Diff: https://reviews.apache.org/r/47324/diff/ > > > Testing > --- > > Tested on Ubuntu amd_64 need to test on PPC > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 47324: Update leveldb to 1.18.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/ --- (Updated Aug. 12, 2016, 4:58 p.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang. Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description (updated) --- Leveldb in modern version is required to support s390x. It's also required to replace default byte-wise comparator with varint comparator in `src/log/leveldb.cpp`. Diffs - 3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe 3rdparty/leveldb-1.18.patch PRE-CREATION 3rdparty/leveldb-1.18.tar.gz PRE-CREATION 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5 Diff: https://reviews.apache.org/r/47324/diff/ Testing --- Tested on Ubuntu amd_64 need to test on PPC Thanks, Tomasz Janiszewski
Re: Review Request 47324: Update leveldb to 1.18.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/ --- (Updated Aug. 12, 2016, 4:58 p.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang. Changes --- Rebase Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description (updated) --- Leveldb in modern version is required to support s390x. It's also required to replace default byte-wise comparator with varint comparator in \`src/log/leveldb.cpp\`. Diffs (updated) - 3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe 3rdparty/leveldb-1.18.patch PRE-CREATION 3rdparty/leveldb-1.18.tar.gz PRE-CREATION 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5 Diff: https://reviews.apache.org/r/47324/diff/ Testing --- Tested on Ubuntu amd_64 need to test on PPC Thanks, Tomasz Janiszewski
Re: Review Request 47324: Update leveldb to 1.18.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review133415 --- Ship it! Tested on s390x, SLES12SP1. - Bing Li On May 14, 2016, 3:01 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47324/ > --- > > (Updated May 14, 2016, 3:01 p.m.) > > > Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent > huang. > > > Bugs: MESOS-970 > https://issues.apache.org/jira/browse/MESOS-970 > > > Repository: mesos > > > Description > --- > > Leveldb in modern version is required to support s390x. > It's also required to replace default byte-wise comparator > with varint comparator in `src/log/leveldb.cpp`. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 > 3rdparty/leveldb-1.18.patch PRE-CREATION > 3rdparty/leveldb-1.18.tar.gz PRE-CREATION > 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 > 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 > 3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 > LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b > src/python/native_common/ext_modules.py.in > 2d4a45efa224b32f80ace4542a00062c5ccb06d5 > > Diff: https://reviews.apache.org/r/47324/diff/ > > > Testing > --- > > Tested on Ubuntu amd_64 need to test on PPC > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 47324: Update leveldb to 1.18.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review133327 --- Ship it! I tested on ppc64le with ssl and libevent enabled, it passed. - Zhiwei Chen On May 14, 2016, 11:01 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47324/ > --- > > (Updated May 14, 2016, 11:01 p.m.) > > > Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent > huang. > > > Bugs: MESOS-970 > https://issues.apache.org/jira/browse/MESOS-970 > > > Repository: mesos > > > Description > --- > > Leveldb in modern version is required to support s390x. > It's also required to replace default byte-wise comparator > with varint comparator in `src/log/leveldb.cpp`. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 > 3rdparty/leveldb-1.18.patch PRE-CREATION > 3rdparty/leveldb-1.18.tar.gz PRE-CREATION > 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 > 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 > 3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 > LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b > src/python/native_common/ext_modules.py.in > 2d4a45efa224b32f80ace4542a00062c5ccb06d5 > > Diff: https://reviews.apache.org/r/47324/diff/ > > > Testing > --- > > Tested on Ubuntu amd_64 need to test on PPC > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 47324: Update leveldb to 1.18.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review133278 --- Patch looks great! Reviews applied: [47324] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 14, 2016, 3:01 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47324/ > --- > > (Updated May 14, 2016, 3:01 p.m.) > > > Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent > huang. > > > Bugs: MESOS-970 > https://issues.apache.org/jira/browse/MESOS-970 > > > Repository: mesos > > > Description > --- > > Leveldb in modern version is required to support s390x. > It's also required to replace default byte-wise comparator > with varint comparator in `src/log/leveldb.cpp`. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 > 3rdparty/leveldb-1.18.patch PRE-CREATION > 3rdparty/leveldb-1.18.tar.gz PRE-CREATION > 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 > 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 > 3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 > LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b > src/python/native_common/ext_modules.py.in > 2d4a45efa224b32f80ace4542a00062c5ccb06d5 > > Diff: https://reviews.apache.org/r/47324/diff/ > > > Testing > --- > > Tested on Ubuntu amd_64 need to test on PPC > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 47324: Update leveldb to 1.18.
> On May 14, 2016, 10:11 a.m., haosdent huang wrote: > > I suggest to change Summary and Description to `Upgrade leveldb to 1.18 to > > suport s390x.` > > Tomasz Janiszewski wrote: > Fixed. Actually I need it to fix replica log provlems on ARM > > haosdent huang wrote: > Cool! And thhe description have a 72 characters limit, otherwise could > not pass jenkins. Please update to > > ``` > Leveldb in modern version is required to support s390x. It's also > required to replace default byte-wise comparator with varint comparator > in `src/log/leveldb.cpp`. > ``` Done - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review133263 --- On May 14, 2016, 3:01 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47324/ > --- > > (Updated May 14, 2016, 3:01 p.m.) > > > Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent > huang. > > > Bugs: MESOS-970 > https://issues.apache.org/jira/browse/MESOS-970 > > > Repository: mesos > > > Description > --- > > Leveldb in modern version is required to support s390x. > It's also required to replace default byte-wise comparator > with varint comparator in `src/log/leveldb.cpp`. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 > 3rdparty/leveldb-1.18.patch PRE-CREATION > 3rdparty/leveldb-1.18.tar.gz PRE-CREATION > 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 > 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 > 3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 > LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b > src/python/native_common/ext_modules.py.in > 2d4a45efa224b32f80ace4542a00062c5ccb06d5 > > Diff: https://reviews.apache.org/r/47324/diff/ > > > Testing > --- > > Tested on Ubuntu amd_64 need to test on PPC > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 47324: Update leveldb to 1.18.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/ --- (Updated May 14, 2016, 3:01 p.m.) Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang. Summary (updated) - Update leveldb to 1.18. Bugs: MESOS-970 https://issues.apache.org/jira/browse/MESOS-970 Repository: mesos Description (updated) --- Leveldb in modern version is required to support s390x. It's also required to replace default byte-wise comparator with varint comparator in `src/log/leveldb.cpp`. Diffs (updated) - 3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 3rdparty/leveldb-1.18.patch PRE-CREATION 3rdparty/leveldb-1.18.tar.gz PRE-CREATION 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5 Diff: https://reviews.apache.org/r/47324/diff/ Testing --- Tested on Ubuntu amd_64 need to test on PPC Thanks, Tomasz Janiszewski
