Re: Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47329/#review133037 --- Patch looks great! Reviews applied: [47329] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 13, 2016, 5:39 a.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47329/ > --- > > (Updated May 13, 2016, 5:39 a.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu. > > > Repository: mesos > > > Description > --- > > Added agent flag 'docker_volume_checkpoint_dir'. > > > Diffs > - > > docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f > src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp > 1aff0d40e5ae83dbc87230099f3081ec7890e897 > src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 > src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 > > Diff: https://reviews.apache.org/r/47329/diff/ > > > Testing > --- > > make check > > > Thanks, > > Gilbert Song > >
Re: Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47329/#review133036 --- Ship it! Ship It! - Guangya Liu On 五月 13, 2016, 5:39 a.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47329/ > --- > > (Updated 五月 13, 2016, 5:39 a.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu. > > > Repository: mesos > > > Description > --- > > Added agent flag 'docker_volume_checkpoint_dir'. > > > Diffs > - > > docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f > src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp > 1aff0d40e5ae83dbc87230099f3081ec7890e897 > src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 > src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 > > Diff: https://reviews.apache.org/r/47329/diff/ > > > Testing > --- > > make check > > > Thanks, > > Gilbert Song > >
Re: Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.
> On May 12, 2016, 6:57 p.m., Guangya Liu wrote: > > Do you want to update the configuration.md? > > Jie Yu wrote: > Good catch. @gilbert, can you follow up with a patch? @Guangya, thanks! - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47329/#review133017 --- On May 12, 2016, 10:39 p.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47329/ > --- > > (Updated May 12, 2016, 10:39 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu. > > > Repository: mesos > > > Description > --- > > Added agent flag 'docker_volume_checkpoint_dir'. > > > Diffs > - > > docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f > src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp > 1aff0d40e5ae83dbc87230099f3081ec7890e897 > src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 > src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 > > Diff: https://reviews.apache.org/r/47329/diff/ > > > Testing > --- > > make check > > > Thanks, > > Gilbert Song > >
Re: Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.
> On May 13, 2016, 1:57 a.m., Guangya Liu wrote: > > Do you want to update the configuration.md? Good catch. @gilbert, can you follow up with a patch? - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47329/#review133017 --- On May 13, 2016, 1:34 a.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47329/ > --- > > (Updated May 13, 2016, 1:34 a.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu. > > > Repository: mesos > > > Description > --- > > Added agent flag 'docker_volume_checkpoint_dir'. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f > src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp > 1aff0d40e5ae83dbc87230099f3081ec7890e897 > src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 > src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 > > Diff: https://reviews.apache.org/r/47329/diff/ > > > Testing > --- > > make check > > > Thanks, > > Gilbert Song > >
Re: Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47329/#review133017 --- Do you want to update the configuration.md? - Guangya Liu On 五月 13, 2016, 1:34 a.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47329/ > --- > > (Updated 五月 13, 2016, 1:34 a.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu. > > > Repository: mesos > > > Description > --- > > Added agent flag 'docker_volume_checkpoint_dir'. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f > src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp > 1aff0d40e5ae83dbc87230099f3081ec7890e897 > src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 > src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 > > Diff: https://reviews.apache.org/r/47329/diff/ > > > Testing > --- > > make check > > > Thanks, > > Gilbert Song > >
Re: Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47329/#review133012 --- Ship it! Ship It! - Jie Yu On May 13, 2016, 1:34 a.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47329/ > --- > > (Updated May 13, 2016, 1:34 a.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu. > > > Repository: mesos > > > Description > --- > > Added agent flag 'docker_volume_checkpoint_dir'. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 9cc9de0d1ba7b98f57cb4ac6a515714e4fcc2f1f > src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp > 1aff0d40e5ae83dbc87230099f3081ec7890e897 > src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 > src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 > > Diff: https://reviews.apache.org/r/47329/diff/ > > > Testing > --- > > make check > > > Thanks, > > Gilbert Song > >
