Re: Review Request 47396: Added aufs provisioning backend.

[Guangya Liu]

> On 六月 7, 2016, 2:09 a.m., Guangya Liu wrote:
> > src/tests/environment.cpp, lines 492-495
> > 
> >
> > I think that here also needs to be updated to use your new function 
> > `fs::aufs::supported()` to check `aufs`?
> 
> Jie Yu wrote:
> Hum... this looks weird to me. I am wondering if we can make 
> `fs::supported` understand the sutble details related to overlayfs? Can you 
> guys follow up with a patch. Basically, here, it should be `Try check = 
> fs::supported(fsname);` and inside `fs::supported`, we check special case for 
> overlayfs.
> 
> Guangya Liu wrote:
> I'm now thinking that we may not need the API of `fs::aufs::supported`, 
> the reason that we introduced `fs::overlay::supported` is becuase of keyword 
> issue, the overlay fs keyword in `/proc/filesystems` can be `overlay` or 
> `overlayfs`.
> 
> But for `aufs`, I think we do not need to introduce the new API of 
> `fs::aufs::supported` but call `fs::supported` directly, as the API of 
> `fs::aufs::supported` is just a wrapper of `fs::supported`. Comments?
> 
> Jie Yu wrote:
> Yeah, I agree with you Guangya. I think we should make 
> `fs::supported(fsname)` understand both overlayfs and overlay and get rid of 
> all fs::xxx::supported logics. Do you have time to follow up with a patch?
> 
> Guangya Liu wrote:
> Hi Yu Jie, it may be difficult to make `fs::supported(fsname)` to 
> understand both overlayfs and overlay, so my thinking is that we only keep 
> `fs::overlay::supported` but remove the `fs::aufs::supported`, comments?
> 
> Jie Yu wrote:
> Why it's difficult to make fs::supported(fsname) to understand both 
> overlayfs and overlay?
> 
> Guangya Liu wrote:
> My first thinking is as https://reviews.apache.org/r/44421/diff/1/
> 
> But considering this will change the parameter of `fs::supported`, so we 
> decide to add `fs::overlay::supported`.  Comments?
> 
> Jie Yu wrote:
> Let's not change the parameter of fs::supported, instead, change the 
> logic inside fs::supported so that it handles overlay/overlayfs well.
> 
> Guangya Liu wrote:
> Got it, then the `fs::supported` may have some special logic for 
> `overlay` and `overlayfs`, I will post a patch later for this.

I posted two patches here

https://reviews.apache.org/r/48618/ Refactored overlay, overlayfs and aufs 
check to fs::supported.
https://reviews.apache.org/r/48619/ Removed fs::aufs::supported and 
fs::overlay::supported.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136392
---


On 六月 6, 2016, 11:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated 六月 6, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Guangya Liu]

> On 六月 7, 2016, 2:09 a.m., Guangya Liu wrote:
> > src/tests/environment.cpp, lines 492-495
> > 
> >
> > I think that here also needs to be updated to use your new function 
> > `fs::aufs::supported()` to check `aufs`?
> 
> Jie Yu wrote:
> Hum... this looks weird to me. I am wondering if we can make 
> `fs::supported` understand the sutble details related to overlayfs? Can you 
> guys follow up with a patch. Basically, here, it should be `Try check = 
> fs::supported(fsname);` and inside `fs::supported`, we check special case for 
> overlayfs.
> 
> Guangya Liu wrote:
> I'm now thinking that we may not need the API of `fs::aufs::supported`, 
> the reason that we introduced `fs::overlay::supported` is becuase of keyword 
> issue, the overlay fs keyword in `/proc/filesystems` can be `overlay` or 
> `overlayfs`.
> 
> But for `aufs`, I think we do not need to introduce the new API of 
> `fs::aufs::supported` but call `fs::supported` directly, as the API of 
> `fs::aufs::supported` is just a wrapper of `fs::supported`. Comments?
> 
> Jie Yu wrote:
> Yeah, I agree with you Guangya. I think we should make 
> `fs::supported(fsname)` understand both overlayfs and overlay and get rid of 
> all fs::xxx::supported logics. Do you have time to follow up with a patch?
> 
> Guangya Liu wrote:
> Hi Yu Jie, it may be difficult to make `fs::supported(fsname)` to 
> understand both overlayfs and overlay, so my thinking is that we only keep 
> `fs::overlay::supported` but remove the `fs::aufs::supported`, comments?
> 
> Jie Yu wrote:
> Why it's difficult to make fs::supported(fsname) to understand both 
> overlayfs and overlay?
> 
> Guangya Liu wrote:
> My first thinking is as https://reviews.apache.org/r/44421/diff/1/
> 
> But considering this will change the parameter of `fs::supported`, so we 
> decide to add `fs::overlay::supported`.  Comments?
> 
> Jie Yu wrote:
> Let's not change the parameter of fs::supported, instead, change the 
> logic inside fs::supported so that it handles overlay/overlayfs well.

Got it, then the `fs::supported` may have some special logic for `overlay` and 
`overlayfs`, I will post a patch later for this.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136392
---


On 六月 6, 2016, 11:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated 六月 6, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Jie Yu]

> On June 7, 2016, 2:09 a.m., Guangya Liu wrote:
> > src/tests/environment.cpp, lines 492-495
> > 
> >
> > I think that here also needs to be updated to use your new function 
> > `fs::aufs::supported()` to check `aufs`?
> 
> Jie Yu wrote:
> Hum... this looks weird to me. I am wondering if we can make 
> `fs::supported` understand the sutble details related to overlayfs? Can you 
> guys follow up with a patch. Basically, here, it should be `Try check = 
> fs::supported(fsname);` and inside `fs::supported`, we check special case for 
> overlayfs.
> 
> Guangya Liu wrote:
> I'm now thinking that we may not need the API of `fs::aufs::supported`, 
> the reason that we introduced `fs::overlay::supported` is becuase of keyword 
> issue, the overlay fs keyword in `/proc/filesystems` can be `overlay` or 
> `overlayfs`.
> 
> But for `aufs`, I think we do not need to introduce the new API of 
> `fs::aufs::supported` but call `fs::supported` directly, as the API of 
> `fs::aufs::supported` is just a wrapper of `fs::supported`. Comments?
> 
> Jie Yu wrote:
> Yeah, I agree with you Guangya. I think we should make 
> `fs::supported(fsname)` understand both overlayfs and overlay and get rid of 
> all fs::xxx::supported logics. Do you have time to follow up with a patch?
> 
> Guangya Liu wrote:
> Hi Yu Jie, it may be difficult to make `fs::supported(fsname)` to 
> understand both overlayfs and overlay, so my thinking is that we only keep 
> `fs::overlay::supported` but remove the `fs::aufs::supported`, comments?
> 
> Jie Yu wrote:
> Why it's difficult to make fs::supported(fsname) to understand both 
> overlayfs and overlay?
> 
> Guangya Liu wrote:
> My first thinking is as https://reviews.apache.org/r/44421/diff/1/
> 
> But considering this will change the parameter of `fs::supported`, so we 
> decide to add `fs::overlay::supported`.  Comments?

Let's not change the parameter of fs::supported, instead, change the logic 
inside fs::supported so that it handles overlay/overlayfs well.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136392
---


On June 6, 2016, 11:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated June 6, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Guangya Liu]

> On 六月 7, 2016, 2:09 a.m., Guangya Liu wrote:
> > src/tests/environment.cpp, lines 492-495
> > 
> >
> > I think that here also needs to be updated to use your new function 
> > `fs::aufs::supported()` to check `aufs`?
> 
> Jie Yu wrote:
> Hum... this looks weird to me. I am wondering if we can make 
> `fs::supported` understand the sutble details related to overlayfs? Can you 
> guys follow up with a patch. Basically, here, it should be `Try check = 
> fs::supported(fsname);` and inside `fs::supported`, we check special case for 
> overlayfs.
> 
> Guangya Liu wrote:
> I'm now thinking that we may not need the API of `fs::aufs::supported`, 
> the reason that we introduced `fs::overlay::supported` is becuase of keyword 
> issue, the overlay fs keyword in `/proc/filesystems` can be `overlay` or 
> `overlayfs`.
> 
> But for `aufs`, I think we do not need to introduce the new API of 
> `fs::aufs::supported` but call `fs::supported` directly, as the API of 
> `fs::aufs::supported` is just a wrapper of `fs::supported`. Comments?
> 
> Jie Yu wrote:
> Yeah, I agree with you Guangya. I think we should make 
> `fs::supported(fsname)` understand both overlayfs and overlay and get rid of 
> all fs::xxx::supported logics. Do you have time to follow up with a patch?
> 
> Guangya Liu wrote:
> Hi Yu Jie, it may be difficult to make `fs::supported(fsname)` to 
> understand both overlayfs and overlay, so my thinking is that we only keep 
> `fs::overlay::supported` but remove the `fs::aufs::supported`, comments?
> 
> Jie Yu wrote:
> Why it's difficult to make fs::supported(fsname) to understand both 
> overlayfs and overlay?

My first thinking is as https://reviews.apache.org/r/44421/diff/1/

But considering this will change the parameter of `fs::supported`, so we decide 
to add `fs::overlay::supported`.  Comments?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136392
---


On 六月 6, 2016, 11:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated 六月 6, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Jie Yu]

> On June 7, 2016, 2:09 a.m., Guangya Liu wrote:
> > src/tests/environment.cpp, lines 492-495
> > 
> >
> > I think that here also needs to be updated to use your new function 
> > `fs::aufs::supported()` to check `aufs`?
> 
> Jie Yu wrote:
> Hum... this looks weird to me. I am wondering if we can make 
> `fs::supported` understand the sutble details related to overlayfs? Can you 
> guys follow up with a patch. Basically, here, it should be `Try check = 
> fs::supported(fsname);` and inside `fs::supported`, we check special case for 
> overlayfs.
> 
> Guangya Liu wrote:
> I'm now thinking that we may not need the API of `fs::aufs::supported`, 
> the reason that we introduced `fs::overlay::supported` is becuase of keyword 
> issue, the overlay fs keyword in `/proc/filesystems` can be `overlay` or 
> `overlayfs`.
> 
> But for `aufs`, I think we do not need to introduce the new API of 
> `fs::aufs::supported` but call `fs::supported` directly, as the API of 
> `fs::aufs::supported` is just a wrapper of `fs::supported`. Comments?
> 
> Jie Yu wrote:
> Yeah, I agree with you Guangya. I think we should make 
> `fs::supported(fsname)` understand both overlayfs and overlay and get rid of 
> all fs::xxx::supported logics. Do you have time to follow up with a patch?
> 
> Guangya Liu wrote:
> Hi Yu Jie, it may be difficult to make `fs::supported(fsname)` to 
> understand both overlayfs and overlay, so my thinking is that we only keep 
> `fs::overlay::supported` but remove the `fs::aufs::supported`, comments?

Why it's difficult to make fs::supported(fsname) to understand both overlayfs 
and overlay?


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136392
---


On June 6, 2016, 11:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated June 6, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Guangya Liu]

> On 六月 7, 2016, 2:09 a.m., Guangya Liu wrote:
> > src/tests/environment.cpp, lines 492-495
> > 
> >
> > I think that here also needs to be updated to use your new function 
> > `fs::aufs::supported()` to check `aufs`?
> 
> Jie Yu wrote:
> Hum... this looks weird to me. I am wondering if we can make 
> `fs::supported` understand the sutble details related to overlayfs? Can you 
> guys follow up with a patch. Basically, here, it should be `Try check = 
> fs::supported(fsname);` and inside `fs::supported`, we check special case for 
> overlayfs.
> 
> Guangya Liu wrote:
> I'm now thinking that we may not need the API of `fs::aufs::supported`, 
> the reason that we introduced `fs::overlay::supported` is becuase of keyword 
> issue, the overlay fs keyword in `/proc/filesystems` can be `overlay` or 
> `overlayfs`.
> 
> But for `aufs`, I think we do not need to introduce the new API of 
> `fs::aufs::supported` but call `fs::supported` directly, as the API of 
> `fs::aufs::supported` is just a wrapper of `fs::supported`. Comments?
> 
> Jie Yu wrote:
> Yeah, I agree with you Guangya. I think we should make 
> `fs::supported(fsname)` understand both overlayfs and overlay and get rid of 
> all fs::xxx::supported logics. Do you have time to follow up with a patch?

Hi Yu Jie, it may be difficult to make `fs::supported(fsname)` to understand 
both overlayfs and overlay, so my thinking is that we only keep 
`fs::overlay::supported` but remove the `fs::aufs::supported`, comments?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136392
---


On 六月 6, 2016, 11:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated 六月 6, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Jie Yu]

> On June 7, 2016, 2:09 a.m., Guangya Liu wrote:
> > src/tests/environment.cpp, lines 492-495
> > 
> >
> > I think that here also needs to be updated to use your new function 
> > `fs::aufs::supported()` to check `aufs`?
> 
> Jie Yu wrote:
> Hum... this looks weird to me. I am wondering if we can make 
> `fs::supported` understand the sutble details related to overlayfs? Can you 
> guys follow up with a patch. Basically, here, it should be `Try check = 
> fs::supported(fsname);` and inside `fs::supported`, we check special case for 
> overlayfs.
> 
> Guangya Liu wrote:
> I'm now thinking that we may not need the API of `fs::aufs::supported`, 
> the reason that we introduced `fs::overlay::supported` is becuase of keyword 
> issue, the overlay fs keyword in `/proc/filesystems` can be `overlay` or 
> `overlayfs`.
> 
> But for `aufs`, I think we do not need to introduce the new API of 
> `fs::aufs::supported` but call `fs::supported` directly, as the API of 
> `fs::aufs::supported` is just a wrapper of `fs::supported`. Comments?

Yeah, I agree with you Guangya. I think we should make `fs::supported(fsname)` 
understand both overlayfs and overlay and get rid of all fs::xxx::supported 
logics. Do you have time to follow up with a patch?


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136392
---


On June 6, 2016, 11:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated June 6, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Guangya Liu]

> On 六月 7, 2016, 2:09 a.m., Guangya Liu wrote:
> > src/tests/environment.cpp, lines 492-495
> > 
> >
> > I think that here also needs to be updated to use your new function 
> > `fs::aufs::supported()` to check `aufs`?
> 
> Jie Yu wrote:
> Hum... this looks weird to me. I am wondering if we can make 
> `fs::supported` understand the sutble details related to overlayfs? Can you 
> guys follow up with a patch. Basically, here, it should be `Try check = 
> fs::supported(fsname);` and inside `fs::supported`, we check special case for 
> overlayfs.

I'm now thinking that we may not need the API of `fs::aufs::supported`, the 
reason that we introduced `fs::overlay::supported` is becuase of keyword issue, 
the overlay fs keyword in `/proc/filesystems` can be `overlay` or `overlayfs`.

But for `aufs`, I think we do not need to introduce the new API of 
`fs::aufs::supported` but call `fs::supported` directly, as the API of 
`fs::aufs::supported` is just a wrapper of `fs::supported`. Comments?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136392
---


On 六月 6, 2016, 11:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated 六月 6, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Jie Yu]

> On June 7, 2016, 2:09 a.m., Guangya Liu wrote:
> > src/tests/environment.cpp, lines 492-495
> > 
> >
> > I think that here also needs to be updated to use your new function 
> > `fs::aufs::supported()` to check `aufs`?

Hum... this looks weird to me. I am wondering if we can make `fs::supported` 
understand the sutble details related to overlayfs? Can you guys follow up with 
a patch. Basically, here, it should be `Try check = 
fs::supported(fsname);` and inside `fs::supported`, we check special case for 
overlayfs.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136392
---


On June 6, 2016, 11:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated June 6, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136392
---




src/slave/containerizer/mesos/provisioner/backends/aufs.cpp (lines 139 - 140)


// See http://aufs.sourceforge.net/aufs2/man.html for the
// mount syntax for aufs.

nit: What about update as above to make it less jagged?



src/tests/containerizer/provisioner_backend_tests.cpp (lines 253 - 254)


one line is enough



src/tests/environment.cpp (lines 492 - 495)


I think that here also needs to be updated to use your new function 
`fs::aufs::supported()` to check `aufs`?



src/tests/environment.cpp (lines 544 - 555)


Move this above `OverlayFSFilter` so as to keep alpha order?


- Guangya Liu


On 六月 6, 2016, 11:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated 六月 6, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136393
---



Patch looks great!

Reviews applied: [48300, 47396]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 6, 2016, 11:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated June 6, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/
---

(Updated June 6, 2016, 11:57 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.


Changes
---

Split the fs::aufs::supported() patch, and use nullptr instead of NULL


Bugs: MESOS-4672
https://issues.apache.org/jira/browse/MESOS-4672


Repository: mesos


Description
---

Added aufs provisioning backend.


Diffs (updated)
-

  src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
  src/slave/containerizer/mesos/provisioner/backend.cpp 
b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
  src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_backend_tests.cpp 
bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
  src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 

Diff: https://reviews.apache.org/r/47396/diff/


Testing
---

- Make check on ubuntu 14.04 64bit
- Test manually: start slave with aufs backend, and write a simple script that 
launches tasks with alpine/ubuntu images


Thanks,

Shuai Lin

Re: Review Request 47396: Added aufs provisioning backend.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136284
---


Fix it, then Ship it!





src/linux/fs.hpp (line 169)


Can you split this patch? I would add `aufs::supported()` in the first 
patch, and add the backend in the second patch.


- Jie Yu


On June 6, 2016, 3:08 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated June 6, 2016, 3:08 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/linux/fs.hpp 53faf248297a16dcacf693ebf645a1fcd5477666 
>   src/linux/fs.cpp 3573c3096afe990cbb0c3b411c688fe699cd9e55 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review136276
---



Patch looks great!

Reviews applied: [47396]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 6, 2016, 3:08 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated June 6, 2016, 3:08 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/linux/fs.hpp 53faf248297a16dcacf693ebf645a1fcd5477666 
>   src/linux/fs.cpp 3573c3096afe990cbb0c3b411c688fe699cd9e55 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/
---

(Updated June 6, 2016, 3:08 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.


Changes
---

Address review comments, and rebased on to latest master branch.


Bugs: MESOS-4672
https://issues.apache.org/jira/browse/MESOS-4672


Repository: mesos


Description
---

Added aufs provisioning backend.


Diffs (updated)
-

  src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
  src/linux/fs.hpp 53faf248297a16dcacf693ebf645a1fcd5477666 
  src/linux/fs.cpp 3573c3096afe990cbb0c3b411c688fe699cd9e55 
  src/slave/containerizer/mesos/provisioner/backend.cpp 
b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
  src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_backend_tests.cpp 
bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
  src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf 

Diff: https://reviews.apache.org/r/47396/diff/


Testing
---

- Make check on ubuntu 14.04 64bit
- Test manually: start slave with aufs backend, and write a simple script that 
launches tasks with alpine/ubuntu images


Thanks,

Shuai Lin

Re: Review Request 47396: Added aufs provisioning backend.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review133300
---




src/slave/containerizer/mesos/provisioner/backend.cpp (line 32)


Move this above `bind.hpp`

#ifdef __linux__
#include "slave/containerizer/mesos/provisioner/backends/aufs.hpp"
#endif


- Guangya Liu


On 五月 15, 2016, 10:52 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated 五月 15, 2016, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 011451b6dd463c83adb98c800e3b777c01fc6826 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review133299
---




src/slave/containerizer/mesos/provisioner/backends/aufs.cpp (lines 72 - 79)


I think this is not needed as it was already checked when creat the auts 
backend.



src/slave/containerizer/mesos/provisioner/backends/aufs.cpp (line 137)


blank line above

s/dir/directory



src/slave/containerizer/mesos/provisioner/backends/aufs.cpp (line 150)


blank line above


- Guangya Liu


On 五月 15, 2016, 10:52 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated 五月 15, 2016, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 011451b6dd463c83adb98c800e3b777c01fc6826 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review133297
---



Patch looks great!

Reviews applied: [47396]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 15, 2016, 10:52 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated May 15, 2016, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 011451b6dd463c83adb98c800e3b777c01fc6826 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/
---

(Updated May 15, 2016, 10:52 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.


Bugs: MESOS-4672
https://issues.apache.org/jira/browse/MESOS-4672


Repository: mesos


Description
---

Added aufs provisioning backend.


Diffs (updated)
-

  src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
  src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
  src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
  src/slave/containerizer/mesos/provisioner/backend.cpp 
b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
  src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_backend_tests.cpp 
bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
  src/tests/environment.cpp 011451b6dd463c83adb98c800e3b777c01fc6826 

Diff: https://reviews.apache.org/r/47396/diff/


Testing
---

- Make check on ubuntu 14.04 64bit
- Test manually: start slave with aufs backend, and write a simple script that 
launches tasks with alpine/ubuntu images


Thanks,

Shuai Lin