Re: Review Request 47404: Stout: Implemented `HANDLE` versions of file descriptor functions.

2016-05-23 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47404/
---

(Updated May 23, 2016, 12:39 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5386
https://issues.apache.org/jira/browse/MESOS-5386


Repository: mesos


Description
---

Stout: Implemented `HANDLE` versions of file descriptor functions.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/fcntl.hpp 
14734317d7fb40053ee808745ac3ba8c706a7669 
  3rdparty/stout/include/stout/os/windows/read.hpp 
a10df7358205da9bc9d3176e27db12556bf0e6ae 
  3rdparty/stout/include/stout/os/windows/write.hpp 
9f75568b88db11f9706beb4e7eb45c6e7759b779 

Diff: https://reviews.apache.org/r/47404/diff/


Testing
---


Thanks,

Alex Clemmer



Re: Review Request 47404: Stout: Implemented `HANDLE` versions of file descriptor functions.

2016-05-16 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47404/#review133426
---


Fix it, then Ship it!





3rdparty/stout/include/stout/os/windows/fcntl.hpp (lines 72 - 73)


Is that true?



3rdparty/stout/include/stout/os/windows/read.hpp (line 26)


Can you clarify that this is a forward declaration for an os agnostic read 
in `os/read.hpp`?
Same with write.


- Joris Van Remoortere


On May 16, 2016, 3:23 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47404/
> ---
> 
> (Updated May 16, 2016, 3:23 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-5386
> https://issues.apache.org/jira/browse/MESOS-5386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `HANDLE` versions of file descriptor functions.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/fcntl.hpp 
> 14734317d7fb40053ee808745ac3ba8c706a7669 
>   3rdparty/stout/include/stout/os/windows/read.hpp 
> a10df7358205da9bc9d3176e27db12556bf0e6ae 
>   3rdparty/stout/include/stout/os/windows/write.hpp 
> 9f75568b88db11f9706beb4e7eb45c6e7759b779 
>   3rdparty/stout/include/stout/protobuf.hpp 
> eb4ac8cd738859a119f4f64bf52ae49a5bbef899 
> 
> Diff: https://reviews.apache.org/r/47404/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 47404: Stout: Implemented `HANDLE` versions of file descriptor functions.

2016-05-15 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47404/#review133324
---



Patch looks great!

Reviews applied: [47052, 47053, 47221, 47054, 41632, 47168, 47169, 47386, 
47387, 47388, 47389, 47390, 47391, 47403, 47404]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 16, 2016, 3:23 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47404/
> ---
> 
> (Updated May 16, 2016, 3:23 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-5386
> https://issues.apache.org/jira/browse/MESOS-5386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `HANDLE` versions of file descriptor functions.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/fcntl.hpp 
> 14734317d7fb40053ee808745ac3ba8c706a7669 
>   3rdparty/stout/include/stout/os/windows/read.hpp 
> a10df7358205da9bc9d3176e27db12556bf0e6ae 
>   3rdparty/stout/include/stout/os/windows/write.hpp 
> 9f75568b88db11f9706beb4e7eb45c6e7759b779 
>   3rdparty/stout/include/stout/protobuf.hpp 
> eb4ac8cd738859a119f4f64bf52ae49a5bbef899 
> 
> Diff: https://reviews.apache.org/r/47404/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>