Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/ --- (Updated May 20, 2016, 4:21 a.m.) Review request for mesos, Freddy

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread haosdent huang
> On May 20, 2016, 3:27 a.m., Vinod Kone wrote: > > Looks like you need to rebase, so I made my comments anyway :) > > > > I'm assuming the workflow for generating the website hasn't changed with > > the introduction of erb files? Thank you very much for your view. >I'm assuming the workflow

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/ --- (Updated May 20, 2016, 3:55 a.m.) Review request for mesos, Freddy

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review134090 --- Patch looks great! Reviews applied: [47587] Passed command:

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review134089 --- Looks like you need to rebase, so I made my comments anyway :)

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review134088 --- Ship it! This is great thank you! I'll make some minor

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review134063 --- Ship it! Ship It! - Tomasz Janiszewski On Maj 19, 2016,

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/ --- (Updated May 19, 2016, 10:32 p.m.) Review request for mesos, Freddy

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review133989 --- site/source/index.html.erb (line 57)

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread haosdent huang
> On May 19, 2016, 2:41 p.m., Tomasz Janiszewski wrote: > > site/source/index.html.erb, line 15 > > > > > > Do we have line length policy for site files? > > haosdent huang wrote: > Thank you very much for your

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread haosdent huang
> On May 19, 2016, 2:41 p.m., Tomasz Janiszewski wrote: > > site/source/index.html.erb, line 15 > > > > > > Do we have line length policy for site files? Thank you very much for your reviews, let me fix it. -

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread haosdent huang
> On May 19, 2016, 3 p.m., Tomasz Janiszewski wrote: > > After switching to `.erb` we lost `` and breadcrumbs Good catch! Let me fix. - haosdent --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review133952 --- After switching to `.erb` we lost `` and breadcrumbs - Tomasz

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/#review133949 --- site/source/index.html.erb (line 15)

Re: Review Request 47587: Created separate local data file to manage releases information.

2016-05-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47587/ --- (Updated May 19, 2016, 10:29 a.m.) Review request for mesos, Freddy