Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135674
---


Ship it!




Ship It!

- Vinod Kone


On May 31, 2016, 6:32 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> ---
> 
> (Updated May 31, 2016, 6:32 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
> https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 0fdda31 
>   src/internal/evolve.cpp 4f25f1a 
>   src/master/http.cpp c8d2f46 
>   src/master/master.hpp eeeccdf 
>   src/tests/api_tests.cpp 0b6bfad 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135613
---



Patch looks great!

Reviews applied: [48049]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On May 31, 2016, 6:32 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> ---
> 
> (Updated May 31, 2016, 6:32 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
> https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 0fdda31 
>   src/internal/evolve.cpp 4f25f1a 
>   src/master/http.cpp c8d2f46 
>   src/master/master.hpp eeeccdf 
>   src/tests/api_tests.cpp 0b6bfad 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Abhishek Dasgupta]

> On May 31, 2016, 12:06 a.m., Qian Zhang wrote:
> > src/master/http.cpp, line 1205
> > 
> >
> > I think we are trying to get leading master here, so should we return 
> > `master->leader.get()`?
> 
> Anand Mazumdar wrote:
> We won't ever reach here if the current master is not the leader owing 
> to: https://github.com/apache/mesos/blob/master/src/master/http.cpp#L361
> 
> Hence, doing `master->info()` is fine. 
> 
> For posterity though, let's add an explicit comment and an invariant 
> check:
> 
> ```cpp
> // It is guaranteed that this master has been elected as the leader.
> CHECK(master->elected());
> 
> response.mutable_get_leading_master()->mutable_master_info()->CopyFrom(
> evolve(master->info()));
> ```

Though CHECK(master->elected()) is called before calling getLeadingMaster, 
still I explicitly added againg inside getLeadingMaster.


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135563
---


On May 31, 2016, 6:32 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> ---
> 
> (Updated May 31, 2016, 6:32 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
> https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 0fdda31 
>   src/internal/evolve.cpp 4f25f1a 
>   src/master/http.cpp c8d2f46 
>   src/master/master.hpp eeeccdf 
>   src/tests/api_tests.cpp 0b6bfad 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/
---

(Updated May 31, 2016, 6:32 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-5497
https://issues.apache.org/jira/browse/MESOS-5497


Repository: mesos


Description
---

Implemented GET_LEADING_MASTER Call in v1 master API and
made a minor change in the test case for GET_LOGGING_LEVEL.


Diffs (updated)
-

  src/internal/evolve.hpp 0fdda31 
  src/internal/evolve.cpp 4f25f1a 
  src/master/http.cpp c8d2f46 
  src/master/master.hpp eeeccdf 
  src/tests/api_tests.cpp 0b6bfad 

Diff: https://reviews.apache.org/r/48049/diff/


Testing
---

On Ubuntu 16.04:

sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check


Thanks,

Abhishek Dasgupta

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Anand Mazumdar]

> On May 31, 2016, 12:06 a.m., Qian Zhang wrote:
> > src/master/http.cpp, line 1205
> > 
> >
> > I think we are trying to get leading master here, so should we return 
> > `master->leader.get()`?

We won't ever reach here if the current master is not the leader owing to: 
https://github.com/apache/mesos/blob/master/src/master/http.cpp#L361

Hence, doing `master->info()` is fine. 

For posterity though, let's add an explicit comment and an invariant check:

```cpp
// It is guaranteed that this master has been elected as the leader.
CHECK(master->elected());

response.mutable_get_leading_master()->mutable_master_info()->CopyFrom(
evolve(master->info()));
```


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135563
---


On May 30, 2016, 9:01 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> ---
> 
> (Updated May 30, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
> https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 0fdda31 
>   src/internal/evolve.cpp 4f25f1a 
>   src/master/http.cpp c8d2f46 
>   src/master/master.hpp eeeccdf 
>   src/tests/api_tests.cpp 0b6bfad 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135563
---




src/master/http.cpp (line 1205)


I think we are trying to get leading master here, so should we return 
`master->leader.get()`?


- Qian Zhang


On May 31, 2016, 5:01 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> ---
> 
> (Updated May 31, 2016, 5:01 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
> https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 0fdda31 
>   src/internal/evolve.cpp 4f25f1a 
>   src/master/http.cpp c8d2f46 
>   src/master/master.hpp eeeccdf 
>   src/tests/api_tests.cpp 0b6bfad 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135550
---


Fix it, then Ship it!





src/master/http.cpp (lines 1203 - 1205)


Nit: We try to have the `->` operator on the same line as the initial 
statement and not use it as a continuation on subsequent lines.

How about:

```cpp
response.mutable_get_leading_master()->mutable_master_info()->CopyFrom(
evolve(master->info()));
```


- Anand Mazumdar


On May 30, 2016, 9:01 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> ---
> 
> (Updated May 30, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
> https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 0fdda31 
>   src/internal/evolve.cpp 4f25f1a 
>   src/master/http.cpp c8d2f46 
>   src/master/master.hpp eeeccdf 
>   src/tests/api_tests.cpp 0b6bfad 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/
---

(Updated May 30, 2016, 9:01 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-5497
https://issues.apache.org/jira/browse/MESOS-5497


Repository: mesos


Description
---

Implemented GET_LEADING_MASTER Call in v1 master API and
made a minor change in the test case for GET_LOGGING_LEVEL.


Diffs (updated)
-

  src/internal/evolve.hpp 0fdda31 
  src/internal/evolve.cpp 4f25f1a 
  src/master/http.cpp c8d2f46 
  src/master/master.hpp eeeccdf 
  src/tests/api_tests.cpp 0b6bfad 

Diff: https://reviews.apache.org/r/48049/diff/


Testing
---

On Ubuntu 16.04:

sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check


Thanks,

Abhishek Dasgupta

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135541
---




src/internal/evolve.hpp (line 118)


We don't need the templated arguments. Also, move this function to L58

The signature would be just:

```cpp
v1::MasterInfo evolve(const mesos::MasterInfo& masterInfo);
```



src/internal/evolve.cpp (lines 427 - 442)


We don't need this:

Just do:

```cpp
v1::MasterInfo evolve(const mesos::MasterInfo& masterInfo)
{
  return evolve(masterInfo);
}
```

Also can you move this upto line L143 i.e. after `TaskStatus` evolve



src/master/http.cpp (lines 1203 - 1207)


Just do:

```cpp

response.mutable_get_leading_master()->mutable_master_info()->CopyFrom(evolve(master->info());
```


- Anand Mazumdar


On May 30, 2016, 7:56 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> ---
> 
> (Updated May 30, 2016, 7:56 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
> https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 0fdda31 
>   src/internal/evolve.cpp 4f25f1a 
>   src/master/http.cpp c8d2f46 
>   src/master/master.hpp eeeccdf 
>   src/tests/api_tests.cpp 0b6bfad 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/
---

(Updated May 30, 2016, 7:56 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-5497
https://issues.apache.org/jira/browse/MESOS-5497


Repository: mesos


Description
---

Implemented GET_LEADING_MASTER Call in v1 master API and
made a minor change in the test case for GET_LOGGING_LEVEL.


Diffs (updated)
-

  src/internal/evolve.hpp 0fdda31 
  src/internal/evolve.cpp 4f25f1a 
  src/master/http.cpp c8d2f46 
  src/master/master.hpp eeeccdf 
  src/tests/api_tests.cpp 0b6bfad 

Diff: https://reviews.apache.org/r/48049/diff/


Testing
---

On Ubuntu 16.04:

sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check


Thanks,

Abhishek Dasgupta

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Abhishek Dasgupta]

> On May 30, 2016, 6:54 p.m., Anand Mazumdar wrote:
> > src/internal/evolve.hpp, lines 118-119
> > 
> >
> > This is not quite what I meant. My bad if my initial comment wasn't 
> > clear:
> > 
> > I wanted an `evolve` function from `MasterInfo` to `v1::MasterInfo` and 
> > not to `v1::master::Response` directly.
> > 
> > We use evolve/devolve's to convert from unversioned message to 
> > versioned and vice versa. There is currently no direct equivalent mapping 
> > from a unversioned message to a Response. 
> > 
> > You can then use the `evolve`'ed message to construct the 
> > `v1::master::Response` in `getLeadingMaster`. Makes sense?

Yeah, Actually in other evolve, it is converted from object to response. That's 
why came the misunderstanding.


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135535
---


On May 30, 2016, 6:44 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> ---
> 
> (Updated May 30, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
> https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 0fdda31 
>   src/internal/evolve.cpp 4f25f1a 
>   src/master/http.cpp c8d2f46 
>   src/master/master.hpp eeeccdf 
>   src/tests/api_tests.cpp 0b6bfad 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135535
---




src/internal/evolve.hpp (lines 118 - 119)


This is not quite what I meant. My bad if my initial comment wasn't clear:

I wanted an `evolve` function from `MasterInfo` to `v1::MasterInfo` and not 
to `v1::master::Response` directly.

We use evolve/devolve's to convert from unversioned message to versioned 
and vice versa. There is currently no direct equivalent mapping from a 
unversioned message to a Response. 

You can then use the `evolve`'ed message to construct the 
`v1::master::Response` in `getLeadingMaster`. Makes sense?


- Anand Mazumdar


On May 30, 2016, 6:44 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> ---
> 
> (Updated May 30, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
> https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 0fdda31 
>   src/internal/evolve.cpp 4f25f1a 
>   src/master/http.cpp c8d2f46 
>   src/master/master.hpp eeeccdf 
>   src/tests/api_tests.cpp 0b6bfad 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/
---

(Updated May 30, 2016, 6:44 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-5497
https://issues.apache.org/jira/browse/MESOS-5497


Repository: mesos


Description
---

Implemented GET_LEADING_MASTER Call in v1 master API and
made a minor change in the test case for GET_LOGGING_LEVEL.


Diffs (updated)
-

  src/internal/evolve.hpp 0fdda31 
  src/internal/evolve.cpp 4f25f1a 
  src/master/http.cpp c8d2f46 
  src/master/master.hpp eeeccdf 
  src/tests/api_tests.cpp 0b6bfad 

Diff: https://reviews.apache.org/r/48049/diff/


Testing
---

On Ubuntu 16.04:

sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check


Thanks,

Abhishek Dasgupta

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48049/#review135525
---



LGTM, just one minor issue where we could benefit from implementing the 
functionality in `evolve`.


src/master/http.cpp (line 1192)


New line before. We use 2 new lines to separate elements outside classes.



src/master/http.cpp (line 1201)


New line before



src/master/http.cpp (lines 1204 - 1214)


hmm.. Can't you just implement a evolve function that converts from 
`MasterInfo` to `v1::MasterInfo` and then just use it here?



src/master/http.cpp (line 1210)


New line before



src/master/http.cpp (line 1220)


Delete a extra new line here



src/tests/api_tests.cpp (line 179)


This was already fixed by bbannier in `cb1fbdaa4`. Can you rebase?



src/tests/api_tests.cpp (line 181)


New line here



src/tests/api_tests.cpp (line 183)


Why the extra new line here?



src/tests/api_tests.cpp (line 197)


The `get()` here is redundant. 

Can you just do:

`v1Response->IsInitialized()` and in the other two places in this test.

I know the other tests already use it in this file but it would be good to 
not introduce new ones.  I would clean up the rest in another review.



src/tests/api_tests.cpp (line 199)


Can you swap the order of arguments i.e.

`master.get()->getMasterInfo().ip())` is the the expected argument.



src/tests/api_tests.cpp (line 345)


Ditto, rebase


- Anand Mazumdar


On May 30, 2016, 4:38 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48049/
> ---
> 
> (Updated May 30, 2016, 4:38 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5497
> https://issues.apache.org/jira/browse/MESOS-5497
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_LEADING_MASTER Call in v1 master API and
> made a minor change in the test case for GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 
>   src/master/master.hpp eeeccdfdfd296c2a484764e887564f2e065cfd14 
>   src/tests/api_tests.cpp 1d7a3a9df395805c250148bf6232b00d712c7a05 
> 
> Diff: https://reviews.apache.org/r/48049/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>