Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/ --- (Updated June 17, 2016, 1:27 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/ --- (Updated June 12, 2016, 5:46 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-11 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/ --- (Updated June 11, 2016, 9:24 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-10 Thread haosdent huang
> On June 9, 2016, 9:09 p.m., Joseph Wu wrote: > > src/master/http.cpp, line 662 > > > > > > Here it would make sense to use the `.then(serializer)`. As we discuss in http://search-hadoop.com/m/0Vlr6Uz9otVwkdv we

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-09 Thread Vinod Kone
> On June 9, 2016, 10 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2874 > > > > > > to be consistent with how we did others, lets have this function return > > JSON::Object, i.e., JSON::Protobuf(schedule)

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/#review136909 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 5:49 p.m.,

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/#review136907 --- src/master/http.cpp (line 2874)

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-09 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/#review136890 --- src/master/http.cpp (line 662)

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/ --- (Updated June 9, 2016, 5:31 p.m.) Review request for mesos and Vinod Kone.