Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

2016-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/#review140669 --- Patch looks great! Reviews applied: [49369, 49370, 49574, 49575]

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

2016-07-04 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/ --- (Updated July 4, 2016, 9:22 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

2016-07-04 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/#review140625 --- Ship it! Ship It! - Alexander Rojas On July 3, 2016, 7:51

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

2016-07-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/#review140598 --- Bad patch! Reviews applied: [49575, 49574, 49370, 49369] Failed

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

2016-07-03 Thread Vinod Kone
> On July 3, 2016, 6:15 p.m., Vinod Kone wrote: > > Ship It! can you rebase? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/#review140567

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

2016-07-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/#review140567 --- Ship it! Ship It! - Vinod Kone On July 3, 2016, 5:51 p.m.,

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

2016-07-03 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/ --- (Updated July 3, 2016, 5:51 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

2016-07-03 Thread Joerg Schad
> On July 3, 2016, 5:34 p.m., Vinod Kone wrote: > > src/tests/authorization_tests.cpp, line 2342 > > > > > > hmm. why this change. these tests expect authorization creation to > > fail, so `create` will not tbe

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

2016-07-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/#review140564 --- src/tests/authorization_tests.cpp (line 2342)