Re: Review Request 50556: Added benchmark test for `Resources::filter`.

2016-10-07 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50556/#review151847
---


Ship it!




Ship It!

- Benjamin Mahler


On Oct. 6, 2016, 9:51 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50556/
> ---
> 
> (Updated Oct. 6, 2016, 9:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joris Van Remoortere, Klaus Ma, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5700
> https://issues.apache.org/jira/browse/MESOS-5700
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This benchmark test is using nonRevocable, revocable, unreserved
> and reserved API benchmark test to test the API of filter for
> Resources.
> 
> 
> Diffs
> -
> 
>   src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a 
> 
> Diff: https://reviews.apache.org/r/50556/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> ```
> ./bin/mesos-tests.sh  --benchmark 
> --gtest_filter="Resources_Filter_BENCHMARK_Test.Filters"
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from Resources_Filter_BENCHMARK_Test
> [ RUN  ] Resources_Filter_BENCHMARK_Test.Filters
> Took 351728us to perform 5 'r.nonRevocable()' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> Took 65710us to perform 5 'r.revocable()' operations on cpus(*){REV}:1
> Took 351148us to perform 5 'r.unreserved()' operations on cpus(*):1; 
> gpus(*):1; mem(*):128; disk(*):256
> Took 418719us to perform 5 'r.reserved(role)' operations on cpus(role):1; 
> gpus(role):1; mem(role):128; disk(role):256
> [   OK ] Resources_Filter_BENCHMARK_Test.Filters (1190 ms)
> [--] 1 test from Resources_Filter_BENCHMARK_Test (1190 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (1209 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 50556: Added benchmark test for `Resources::filter`.

2016-10-06 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50556/
---

(Updated 十月 6, 2016, 9:51 a.m.)


Review request for mesos, Benjamin Mahler, Joris Van Remoortere, Klaus Ma, and 
Jiang Yan Xu.


Bugs: MESOS-5700
https://issues.apache.org/jira/browse/MESOS-5700


Repository: mesos


Description
---

This benchmark test is using nonRevocable, revocable, unreserved
and reserved API benchmark test to test the API of filter for
Resources.


Diffs (updated)
-

  src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a 

Diff: https://reviews.apache.org/r/50556/diff/


Testing
---

make
make check

```
./bin/mesos-tests.sh  --benchmark 
--gtest_filter="Resources_Filter_BENCHMARK_Test.Filters"
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from Resources_Filter_BENCHMARK_Test
[ RUN  ] Resources_Filter_BENCHMARK_Test.Filters
Took 351728us to perform 5 'r.nonRevocable()' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 65710us to perform 5 'r.revocable()' operations on cpus(*){REV}:1
Took 351148us to perform 5 'r.unreserved()' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 418719us to perform 5 'r.reserved(role)' operations on cpus(role):1; 
gpus(role):1; mem(role):128; disk(role):256
[   OK ] Resources_Filter_BENCHMARK_Test.Filters (1190 ms)
[--] 1 test from Resources_Filter_BENCHMARK_Test (1190 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (1209 ms total)
[  PASSED  ] 1 test.
```


Thanks,

Guangya Liu

Re: Review Request 50556: Added benchmark test for `Resources::filter`.

2016-10-05 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50556/
---

(Updated 十月 6, 2016, 1:44 a.m.)


Review request for mesos, Benjamin Mahler, Joris Van Remoortere, Klaus Ma, and 
Jiang Yan Xu.


Bugs: MESOS-5700
https://issues.apache.org/jira/browse/MESOS-5700


Repository: mesos


Description
---

This benchmark test is using nonRevocable, revocable, unreserved
and reserved API benchmark test to test the API of filter for
Resources.


Diffs (updated)
-

  src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a 

Diff: https://reviews.apache.org/r/50556/diff/


Testing (updated)
---

make
make check

```
./bin/mesos-tests.sh  --benchmark 
--gtest_filter="Resources_Filter_BENCHMARK_Test.Filters"
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from Resources_Filter_BENCHMARK_Test
[ RUN  ] Resources_Filter_BENCHMARK_Test.Filters
Took 351728us to perform 5 'r.nonRevocable()' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 65710us to perform 5 'r.revocable()' operations on cpus(*){REV}:1
Took 351148us to perform 5 'r.unreserved()' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 418719us to perform 5 'r.reserved(role)' operations on cpus(role):1; 
gpus(role):1; mem(role):128; disk(role):256
[   OK ] Resources_Filter_BENCHMARK_Test.Filters (1190 ms)
[--] 1 test from Resources_Filter_BENCHMARK_Test (1190 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (1209 ms total)
[  PASSED  ] 1 test.
```


Thanks,

Guangya Liu

Re: Review Request 50556: Added benchmark test for `Resources::filter`.

2016-09-22 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50556/
---

(Updated 九月 22, 2016, 9:28 a.m.)


Review request for mesos, Benjamin Mahler, Joris Van Remoortere, Klaus Ma, and 
Jiang Yan Xu.


Bugs: MESOS-5700
https://issues.apache.org/jira/browse/MESOS-5700


Repository: mesos


Description
---

This benchmark test is using nonRevocable, revocable, unreserved
and reserved API benchmark test to test the API of filter for
Resources.


Diffs (updated)
-

  src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a 

Diff: https://reviews.apache.org/r/50556/diff/


Testing
---

make
make check

```
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from Resources_BENCHMARK_Test
[ RUN  ] Resources_BENCHMARK_Test.Filters
Took 853840us to perform 5 'r.nonRevocable()' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 188532us to perform 5 'r.revocable()' operations on cpus(*){REV}:1
Took 836740us to perform 5 'r.unreserved()' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 1.029417secs to perform 5 'r.reserved(role)' operations on 
cpus(role):1; gpus(role):1; mem(role):128; disk(role):256
[   OK ] Resources_BENCHMARK_Test.Filters (2909 ms)
[--] 1 test from Resources_BENCHMARK_Test (2909 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (2932 ms total)
[  PASSED  ] 1 test.
```


Thanks,

Guangya Liu

Re: Review Request 50556: Added benchmark test for `Resources::filter`.

2016-08-04 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50556/
---

(Updated 八月 5, 2016, 5:47 a.m.)


Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma.


Summary (updated)
-

Added benchmark test for `Resources::filter`.


Bugs: MESOS-5700
https://issues.apache.org/jira/browse/MESOS-5700


Repository: mesos


Description (updated)
---

This benchmark test is using nonRevocable, revocable, unreserved
and reserved API benchmark test to test the API of filter for
Resources.


Diffs (updated)
-

  src/tests/resources_tests.cpp e61bdeffd5114ab481903c1178d9ecb3452ec85b 

Diff: https://reviews.apache.org/r/50556/diff/


Testing (updated)
---

make
make check

```
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from Resources_BENCHMARK_Test
[ RUN  ] Resources_BENCHMARK_Test.Filters
Took 853840us to perform 5 'r.nonRevocable()' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 188532us to perform 5 'r.revocable()' operations on cpus(*){REV}:1
Took 836740us to perform 5 'r.unreserved()' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 1.029417secs to perform 5 'r.reserved(role)' operations on 
cpus(role):1; gpus(role):1; mem(role):128; disk(role):256
[   OK ] Resources_BENCHMARK_Test.Filters (2909 ms)
[--] 1 test from Resources_BENCHMARK_Test (2909 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (2932 ms total)
[  PASSED  ] 1 test.
```


Thanks,

Guangya Liu