Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-09-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review150221 --- Ship it! Ship It! - Jie Yu On Sept. 22, 2016, 8:52 p.m.,

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-09-23 Thread Jie Yu
> On Sept. 21, 2016, 6:26 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_backend_tests.cpp, lines 116-131 > > > > > > I'd suggest we create a separate test. Also, i suggest we construct a > > lot of

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review150128 --- Patch looks great! Reviews applied: [51124] Passed command:

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-09-22 Thread Zhitao Li
> On Sept. 21, 2016, 6:26 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_backend_tests.cpp, lines 116-131 > > > > > > I'd suggest we create a separate test. Also, i suggest we construct a > > lot of

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-09-22 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/ --- (Updated Sept. 22, 2016, 8:52 p.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-09-21 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review149874 --- src/slave/containerizer/mesos/provisioner/backends/aufs.cpp

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-09-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review149863 --- THe patch looks good to me. I'd like to adjust the test to better

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-09-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review149766 --- Patch looks great! Reviews applied: [51124] Passed command:

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-09-20 Thread Zhitao Li
> On Sept. 20, 2016, 5:21 p.m., Gilbert Song wrote: > > @Zhitao, the patch LGTM. Thanks for working on it. Could you please rebase? Done. - Zhitao --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-09-20 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/ --- (Updated Sept. 20, 2016, 5:28 p.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-09-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review149683 --- @Zhitao, the patch LGTM. Thanks for working on it. Could you

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review146833 --- Patch looks great! Reviews applied: [51124] Passed command:

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-25 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/ --- (Updated Aug. 25, 2016, 4:22 p.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-25 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/ --- (Updated Aug. 25, 2016, 4:13 p.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-25 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review146749 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review146732 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review145847 --- Patch looks great! Reviews applied: [51124] Passed command: