Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

2016-09-26 Thread Benjamin Hindman
> On Sept. 25, 2016, 10:32 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/linux_launcher.cpp, line 614 > > > > > > using executor_pid here is weird. I think we should rethink how we > > should

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

2016-09-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/#review150481 --- Ship it! Ship It! - Jie Yu On Sept. 25, 2016, 4:08 p.m.,

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

2016-09-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/#review150361 --- src/slave/containerizer/mesos/linux_launcher.cpp (line 105)

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

2016-09-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/#review150346 --- src/slave/containerizer/mesos/linux_launcher.cpp (line 578)

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

2016-09-25 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/ --- (Updated Sept. 25, 2016, 4:08 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

2016-09-25 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/ --- (Updated Sept. 25, 2016, 4:07 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

2016-08-24 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/#review146740 --- src/slave/containerizer/mesos/linux_launcher.cpp (line 132)

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

2016-08-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/#review146532 --- src/slave/containerizer/mesos/linux_launcher.hpp (lines 20 - 22)

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

2016-08-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/#review146309 --- Patch looks great! Reviews applied: [51272, 51273, 51274, 51275,