Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/ --- (Updated Aug. 26, 2016, 1:52 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/ --- (Updated Aug. 26, 2016, 12:34 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Jie Yu
> On Aug. 25, 2016, 5:34 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 502 > > > > > > I'd avoid using subprocess here. Using subprocess here means that we'll > > initialize libprocess,

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/ --- (Updated Aug. 25, 2016, 11:32 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/#review146819 --- src/slave/containerizer/mesos/launcher.cpp (lines 91 - 114)

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/#review146791 --- Can you split the Launcher::wait support to a separate patch?