Re: Review Request 51411: Added provisioner tests to provision using meta discovery.

2017-03-01 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51411/#review167399
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Oct. 16, 2016, 5:58 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51411/
> ---
> 
> (Updated Oct. 16, 2016, 5:58 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4288
> https://issues.apache.org/jira/browse/MESOS-4288
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added two tests that will test two of the image meta discovery paths.
> Test ROOT_MetaDiscoveryAppcImageTest pulls a appc image from quay.io and
> the test ROOT_MetaDiscoveryDockerImageTest pulls a docker image from the
> docker hub. Both tests use "useMetaDiscovery" flag along with other Appc
> image labels to invoke meta discovery algorithm from "rkt" tool.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> a999fc7991da805dfbcdf5659fcfb762aee5b2b9 
> 
> 
> Diff: https://reviews.apache.org/r/51411/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>



Re: Review Request 51411: Added provisioner tests to provision using meta discovery.

2016-10-16 Thread Srinivas Brahmaroutu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51411/
---

(Updated Oct. 16, 2016, 5:58 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
---

Added two tests that will test two of the image meta discovery paths.
Test ROOT_MetaDiscoveryAppcImageTest pulls a appc image from quay.io and
the test ROOT_MetaDiscoveryDockerImageTest pulls a docker image from the
docker hub. Both tests use "useMetaDiscovery" flag along with other Appc
image labels to invoke meta discovery algorithm from "rkt" tool.


Diffs (updated)
-

  src/tests/containerizer/provisioner_appc_tests.cpp 
a999fc7991da805dfbcdf5659fcfb762aee5b2b9 

Diff: https://reviews.apache.org/r/51411/diff/


Testing
---


Thanks,

Srinivas Brahmaroutu



Re: Review Request 51411: Added provisioner tests to provision using meta discovery.

2016-09-18 Thread Srinivas Brahmaroutu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51411/
---

(Updated Sept. 19, 2016, 1:16 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
---

Added two tests that will test two of the image meta discovery paths.
Test ROOT_MetaDiscoveryAppcImageTest pulls a appc image from quay.io and
the test ROOT_MetaDiscoveryDockerImageTest pulls a docker image from the
docker hub. Both tests use "useMetaDiscovery" flag along with other Appc
image labels to invoke meta discovery algorithm from "rkt" tool.


Diffs (updated)
-

  src/tests/containerizer/provisioner_appc_tests.cpp 
6ef1c926d7aa942e241a24d4d3838a5f2d7c4bd1 

Diff: https://reviews.apache.org/r/51411/diff/


Testing
---


Thanks,

Srinivas Brahmaroutu



Re: Review Request 51411: Added provisioner tests to provision using meta discovery.

2016-09-06 Thread Srinivas Brahmaroutu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51411/
---

(Updated Sept. 6, 2016, 8:11 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
---

Added two tests that will test two of the image meta discovery paths.
Test ROOT_MetaDiscoveryAppcImageTest pulls a appc image from quay.io and
the test ROOT_MetaDiscoveryDockerImageTest pulls a docker image from the
docker hub. Both tests use "useMetaDiscovery" flag along with other Appc
image labels to invoke meta discovery algorithm from "rkt" tool.


Diffs (updated)
-

  src/tests/containerizer/provisioner_appc_tests.cpp 
b3ba176e506a6d1528290c07a8a0555b12c8cf70 

Diff: https://reviews.apache.org/r/51411/diff/


Testing
---


Thanks,

Srinivas Brahmaroutu



Re: Review Request 51411: Added provisioner tests to provision using meta discovery.

2016-08-25 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51411/#review146770
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On Aug. 25, 2016, 5:29 a.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51411/
> ---
> 
> (Updated Aug. 25, 2016, 5:29 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4288
> https://issues.apache.org/jira/browse/MESOS-4288
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added two tests that will test two of the image meta discovery paths.
> Test ROOT_MetaDiscoveryAppcImageTest pulls a appc image from quay.io and
> the test ROOT_MetaDiscoveryDockerImageTest pulls a docker image from the
> docker hub. Both tests use "useMetaDiscovery" flag along with other Appc
> image labels to invoke meta discovery algorithm from "rkt" tool.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> b3ba176e506a6d1528290c07a8a0555b12c8cf70 
> 
> Diff: https://reviews.apache.org/r/51411/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>