Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-26 Thread Jiang Yan Xu
> On Sept. 26, 2016, 10:22 a.m., Jiang Yan Xu wrote: > > src/health-check/health_checker.cpp, lines 185-189 > > > > > > How about the following? > > > > ``` > > if (check.has_command() &&

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-26 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review150374 --- src/health-check/health_checker.cpp (lines 185 - 189)

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review150204 --- Patch looks great! Reviews applied: [51561, 51803, 51560]

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 23, 2016, 3:38 p.m.) Review request for mesos, Alexander

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review150182 --- src/health-check/health_checker.cpp (line 188)

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review149937 --- Patch looks great! Reviews applied: [51561, 51803, 51560]

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 21, 2016, 6:21 p.m.) Review request for mesos, Alexander

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 21, 2016, 6:19 p.m.) Review request for mesos, Alexander

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 21, 2016, 6:18 p.m.) Review request for mesos, Alexander

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review148537 --- CHANGELOG (line 28)

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review148522 --- Patch looks great! Reviews applied: [51561, 51803, 51560]

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 12, 2016, 2:19 p.m.) Review request for mesos, Alexander

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 12, 2016, 2:16 p.m.) Review request for mesos, Alexander

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review148491 --- CHANGELOG (line 28)

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review148486 --- src/health-check/health_checker.cpp (line 178)

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 12, 2016, 1:18 p.m.) Review request for mesos, Alexander

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 12, 2016, 12:56 p.m.) Review request for mesos, Alexander

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 6, 2016, 8:34 a.m.) Review request for mesos, Alexander

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review147591 --- src/health-check/health_checker.cpp (lines 178 - 186)

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-09-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 1, 2016, 6:18 p.m.) Review request for mesos, Alexander

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-08-31 Thread haosdent huang
> On Aug. 31, 2016, 7:07 p.m., Silas Snider wrote: > > src/health-check/health_checker.cpp, line 183 > > > > > > This is incorrect. In 1.0.0, you could specify *either* HTTP *or* > > Command healthcheck without

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-08-31 Thread Silas Snider
> On Aug. 31, 2016, 7:07 p.m., Silas Snider wrote: > > src/health-check/health_checker.cpp, line 183 > > > > > > This is incorrect. In 1.0.0, you could specify *either* HTTP *or* > > Command healthcheck without

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-08-31 Thread haosdent huang
> On Aug. 31, 2016, 7:07 p.m., Silas Snider wrote: > > src/health-check/health_checker.cpp, line 183 > > > > > > This is incorrect. In 1.0.0, you could specify *either* HTTP *or* > > Command healthcheck without

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-08-31 Thread Silas Snider
> On Aug. 31, 2016, 7:07 p.m., Silas Snider wrote: > > src/health-check/health_checker.cpp, line 183 > > > > > > This is incorrect. In 1.0.0, you could specify *either* HTTP *or* > > Command healthcheck without

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-08-31 Thread Silas Snider
> On Aug. 31, 2016, 7:07 p.m., Silas Snider wrote: > > src/health-check/health_checker.cpp, line 183 > > > > > > This is incorrect. In 1.0.0, you could specify *either* HTTP *or* > > Command healthcheck without

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-08-31 Thread haosdent huang
> On Aug. 31, 2016, 7:07 p.m., Silas Snider wrote: > > src/health-check/health_checker.cpp, line 183 > > > > > > This is incorrect. In 1.0.0, you could specify *either* HTTP *or* > > Command healthcheck without

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-08-31 Thread Silas Snider
> On Aug. 31, 2016, 7:07 p.m., Silas Snider wrote: > > src/health-check/health_checker.cpp, line 183 > > > > > > This is incorrect. In 1.0.0, you could specify *either* HTTP *or* > > Command healthcheck without

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-08-31 Thread haosdent huang
> On Aug. 31, 2016, 7:07 p.m., Silas Snider wrote: > > src/health-check/health_checker.cpp, line 183 > > > > > > This is incorrect. In 1.0.0, you could specify *either* HTTP *or* > > Command healthcheck without

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-08-31 Thread Silas Snider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review147468 --- src/health-check/health_checker.cpp (line 183)

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-08-31 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review147463 --- src/health-check/health_checker.cpp (line 178)

Re: Review Request 51560: Deprecated using health checks without setting the type.

2016-08-31 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Aug. 31, 2016, 6:29 p.m.) Review request for mesos, Alexander