Re: Review Request 51636: Reverted "Moved `process::internal::defaultClone` to `process::`.".
> On Sept. 22, 2016, 12:03 p.m., Alexander Rukletsov wrote: > > Please split into libprocess/non-libprocess patches. > > Jie Yu wrote: > Let's just do git revert. Sounds like last time, you guys didn't split > the patch? > > Alexander Rukletsov wrote: > We can't revert without adjusting to it. We should commit two patches > simultaneously: git revert + an extra patch. > > I would rather not do it now and switch to a child hook altogether. SGTM. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51636/#review149986 --- On Sept. 5, 2016, 6:40 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51636/ > --- > > (Updated Sept. 5, 2016, 6:40 p.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Bugs: MESOS-5961 > https://issues.apache.org/jira/browse/MESOS-5961 > > > Repository: mesos > > > Description > --- > > This reverts commit d2f8bfabe48bee5533c30afaecbcf76ef081248f. > > > Diffs > - > > 3rdparty/libprocess/include/process/posix/subprocess.hpp > 57f71d15e6fbb032c8b6c5d0c73a93751022e7e7 > src/health-check/health_checker.cpp > f373df19fc8af8e9650be61e3b101e89362a67cd > > Diff: https://reviews.apache.org/r/51636/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 51636: Reverted "Moved `process::internal::defaultClone` to `process::`.".
> On Sept. 22, 2016, 12:03 p.m., Alexander Rukletsov wrote: > > Please split into libprocess/non-libprocess patches. > > Jie Yu wrote: > Let's just do git revert. Sounds like last time, you guys didn't split > the patch? We can't revert without adjusting to it. We should commit two patches simultaneously: git revert + an extra patch. I would rather not do it now and switch to a child hook altogether. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51636/#review149986 --- On Sept. 5, 2016, 6:40 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51636/ > --- > > (Updated Sept. 5, 2016, 6:40 p.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Bugs: MESOS-5961 > https://issues.apache.org/jira/browse/MESOS-5961 > > > Repository: mesos > > > Description > --- > > This reverts commit d2f8bfabe48bee5533c30afaecbcf76ef081248f. > > > Diffs > - > > 3rdparty/libprocess/include/process/posix/subprocess.hpp > 57f71d15e6fbb032c8b6c5d0c73a93751022e7e7 > src/health-check/health_checker.cpp > f373df19fc8af8e9650be61e3b101e89362a67cd > > Diff: https://reviews.apache.org/r/51636/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 51636: Reverted "Moved `process::internal::defaultClone` to `process::`.".
> On Sept. 22, 2016, 12:03 p.m., Alexander Rukletsov wrote: > > Please split into libprocess/non-libprocess patches. Let's just do git revert. Sounds like last time, you guys didn't split the patch? - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51636/#review149986 --- On Sept. 5, 2016, 6:40 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51636/ > --- > > (Updated Sept. 5, 2016, 6:40 p.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Bugs: MESOS-5961 > https://issues.apache.org/jira/browse/MESOS-5961 > > > Repository: mesos > > > Description > --- > > This reverts commit d2f8bfabe48bee5533c30afaecbcf76ef081248f. > > > Diffs > - > > 3rdparty/libprocess/include/process/posix/subprocess.hpp > 57f71d15e6fbb032c8b6c5d0c73a93751022e7e7 > src/health-check/health_checker.cpp > f373df19fc8af8e9650be61e3b101e89362a67cd > > Diff: https://reviews.apache.org/r/51636/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 51636: Reverted "Moved `process::internal::defaultClone` to `process::`.".
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51636/#review149986 --- Please split into libprocess/non-libprocess patches. - Alexander Rukletsov On Sept. 5, 2016, 6:40 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51636/ > --- > > (Updated Sept. 5, 2016, 6:40 p.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Bugs: MESOS-5961 > https://issues.apache.org/jira/browse/MESOS-5961 > > > Repository: mesos > > > Description > --- > > This reverts commit d2f8bfabe48bee5533c30afaecbcf76ef081248f. > > > Diffs > - > > 3rdparty/libprocess/include/process/posix/subprocess.hpp > 57f71d15e6fbb032c8b6c5d0c73a93751022e7e7 > src/health-check/health_checker.cpp > f373df19fc8af8e9650be61e3b101e89362a67cd > > Diff: https://reviews.apache.org/r/51636/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 51636: Reverted "Moved `process::internal::defaultClone` to `process::`.".
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51636/#review147780 --- Patch looks great! Reviews applied: [51636] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 5, 2016, 6:40 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51636/ > --- > > (Updated Sept. 5, 2016, 6:40 p.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Bugs: MESOS-5961 > https://issues.apache.org/jira/browse/MESOS-5961 > > > Repository: mesos > > > Description > --- > > This reverts commit d2f8bfabe48bee5533c30afaecbcf76ef081248f. > > > Diffs > - > > 3rdparty/libprocess/include/process/posix/subprocess.hpp > 57f71d15e6fbb032c8b6c5d0c73a93751022e7e7 > src/health-check/health_checker.cpp > f373df19fc8af8e9650be61e3b101e89362a67cd > > Diff: https://reviews.apache.org/r/51636/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 51636: Reverted "Moved `process::internal::defaultClone` to `process::`.".
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51636/#review147774 --- Ship it! Ship It! - Jie Yu On Sept. 5, 2016, 6:40 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51636/ > --- > > (Updated Sept. 5, 2016, 6:40 p.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Bugs: MESOS-5961 > https://issues.apache.org/jira/browse/MESOS-5961 > > > Repository: mesos > > > Description > --- > > This reverts commit d2f8bfabe48bee5533c30afaecbcf76ef081248f. > > > Diffs > - > > 3rdparty/libprocess/include/process/posix/subprocess.hpp > 57f71d15e6fbb032c8b6c5d0c73a93751022e7e7 > src/health-check/health_checker.cpp > f373df19fc8af8e9650be61e3b101e89362a67cd > > Diff: https://reviews.apache.org/r/51636/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
