Re: Review Request 51905: Added logging when sending a queued task group to the executor.

2016-09-15 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51905/#review149144
---


Ship it!




Ship It!

- Vinod Kone


On Sept. 15, 2016, 4:34 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51905/
> ---
> 
> (Updated Sept. 15, 2016, 4:34 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We were not logging the task group before sending the queued
> task group to the executor via a `LAUNCH_GROUP` event.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 863ab9d9c9332ac618fd102c096c7aa39343c0fe 
> 
> Diff: https://reviews.apache.org/r/51905/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 51905: Added logging when sending a queued task group to the executor.

2016-09-15 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51905/#review149029
---



Patch looks great!

Reviews applied: [51904, 51905]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 15, 2016, 4:34 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51905/
> ---
> 
> (Updated Sept. 15, 2016, 4:34 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We were not logging the task group before sending the queued
> task group to the executor via a `LAUNCH_GROUP` event.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 863ab9d9c9332ac618fd102c096c7aa39343c0fe 
> 
> Diff: https://reviews.apache.org/r/51905/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>