Re: Review Request 51946: Updated test for BadACLNoPrincipal and BadACLDropCreateAndDestroy.

2016-10-04 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51946/#review151340
---


Ship it!




Thanks Guangya!

- Greg Mann


On Oct. 3, 2016, 9:53 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51946/
> ---
> 
> (Updated Oct. 3, 2016, 9:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6181
> https://issues.apache.org/jira/browse/MESOS-6181
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If destroy volume failed, we should get the latest offer to make
> sure that the latest offer contain the volume resource.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 2ab44d11d159162dfcac9d0791b651ed059b8164 
> 
> Diff: https://reviews.apache.org/r/51946/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="*PersistentVolumeTest.BadACL*/*"  
> --gtest_repeat=20
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 51946: Updated test for BadACLNoPrincipal and BadACLDropCreateAndDestroy.

2016-10-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51946/#review151307
---



Patch looks great!

Reviews applied: [51946]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 3, 2016, 9:53 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51946/
> ---
> 
> (Updated Oct. 3, 2016, 9:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6181
> https://issues.apache.org/jira/browse/MESOS-6181
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If destroy volume failed, we should get the latest offer to make
> sure that the latest offer contain the volume resource.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 2ab44d11d159162dfcac9d0791b651ed059b8164 
> 
> Diff: https://reviews.apache.org/r/51946/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="*PersistentVolumeTest.BadACL*/*"  
> --gtest_repeat=20
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 51946: Updated test for BadACLNoPrincipal and BadACLDropCreateAndDestroy.

2016-10-03 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51946/
---

(Updated 十月 3, 2016, 9:53 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and Jiang Yan Xu.


Bugs: MESOS-6181
https://issues.apache.org/jira/browse/MESOS-6181


Repository: mesos


Description (updated)
---

If destroy volume failed, we should get the latest offer to make
sure that the latest offer contain the volume resource.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
2ab44d11d159162dfcac9d0791b651ed059b8164 

Diff: https://reviews.apache.org/r/51946/diff/


Testing
---

make
make check

```
./bin/mesos-tests.sh --gtest_filter="*PersistentVolumeTest.BadACL*/*"  
--gtest_repeat=20
```


Thanks,

Guangya Liu

Re: Review Request 51946: Updated test for BadACLNoPrincipal and BadACLDropCreateAndDestroy.

2016-10-03 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51946/#review151222
---




src/tests/persistent_volume_tests.cpp 


What do you think about leaving the `{}` braces, for readability?


- Greg Mann


On Sept. 16, 2016, 8:36 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51946/
> ---
> 
> (Updated Sept. 16, 2016, 8:36 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6181
> https://issues.apache.org/jira/browse/MESOS-6181
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Two updates:
> 1) Kill the `{}` in the test case as there is no need to add `{}`,
> adding the `{}` will cause the driver decline a non exist offer.
> 2) If destroy volume failed, we should get the last offer to make
> sure that the last offer also contain the volume resource.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> c38d8484fbd62b36bf124a96d17c8cae5e51e594 
> 
> Diff: https://reviews.apache.org/r/51946/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="*PersistentVolumeTest.BadACL*/*"  
> --gtest_repeat=20
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 51946: Updated test for BadACLNoPrincipal and BadACLDropCreateAndDestroy.

2016-09-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51946/#review149183
---



Patch looks great!

Reviews applied: [51946]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 16, 2016, 8:36 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51946/
> ---
> 
> (Updated Sept. 16, 2016, 8:36 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6181
> https://issues.apache.org/jira/browse/MESOS-6181
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Two updates:
> 1) Kill the `{}` in the test case as there is no need to add `{}`,
> adding the `{}` will cause the driver decline a non exist offer.
> 2) If destroy volume failed, we should get the last offer to make
> sure that the last offer also contain the volume resource.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> c38d8484fbd62b36bf124a96d17c8cae5e51e594 
> 
> Diff: https://reviews.apache.org/r/51946/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="*PersistentVolumeTest.BadACL*/*"  
> --gtest_repeat=20
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>