Re: Review Request 51958: Removed use of "--registry_strict" master flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51958/#review149542 --- Ship it! Ship It! - Vinod Kone On Sept. 17, 2016, 2:23 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51958/ > --- > > (Updated Sept. 17, 2016, 2:23 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5951 > https://issues.apache.org/jira/browse/MESOS-5951 > > > Repository: mesos > > > Description > --- > > The flag will remain for a few more months per the deprecation policy, > but we no longer need to set it in the unit tests. Providing an > extensive usage summary in "--help" output also doesn't seem useful. > > > Diffs > - > > src/master/flags.cpp 19ae6c1c30a1054b64a9585f325bd0bf943af218 > src/tests/cluster.cpp b04653af97d17aaa9d0d3ee872169b66cd67126b > src/tests/mesos.cpp 07a64f0ff49a753ec26260cdf859d0584c3f935a > > Diff: https://reviews.apache.org/r/51958/diff/ > > > Testing > --- > > `make check` on OSX and Linux. > > > Thanks, > > Neil Conway > >
Re: Review Request 51958: Removed use of "--registry_strict" master flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51958/#review149331 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418, 50422, 50699, 50700, 50701, 50702, 50703, 50704, 50705, 50706, 50707, 50844, 50845, 50846, 51020, 51371, 51374, 51375, 51376, 51377, 51021, 51706, 51653, 51707, 51805, 51845, 51891, 51909, 51913, 51953, 51954, 51955, 51956, 51957, 51958] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 17, 2016, 2:23 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51958/ > --- > > (Updated Sept. 17, 2016, 2:23 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5951 > https://issues.apache.org/jira/browse/MESOS-5951 > > > Repository: mesos > > > Description > --- > > The flag will remain for a few more months per the deprecation policy, > but we no longer need to set it in the unit tests. Providing an > extensive usage summary in "--help" output also doesn't seem useful. > > > Diffs > - > > src/master/flags.cpp 19ae6c1c30a1054b64a9585f325bd0bf943af218 > src/tests/cluster.cpp b04653af97d17aaa9d0d3ee872169b66cd67126b > src/tests/mesos.cpp 07a64f0ff49a753ec26260cdf859d0584c3f935a > > Diff: https://reviews.apache.org/r/51958/diff/ > > > Testing > --- > > `make check` on OSX and Linux. > > > Thanks, > > Neil Conway > >
Re: Review Request 51958: Removed use of "--registry_strict" master flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51958/ --- (Updated Sept. 17, 2016, 2:23 p.m.) Review request for mesos and Vinod Kone. Changes --- Per review comment: keep flag for now, remove some uses of it. Summary (updated) - Removed use of "--registry_strict" master flag. Bugs: MESOS-5951 https://issues.apache.org/jira/browse/MESOS-5951 Repository: mesos Description (updated) --- The flag will remain for a few more months per the deprecation policy, but we no longer need to set it in the unit tests. Providing an extensive usage summary in "--help" output also doesn't seem useful. Diffs (updated) - src/master/flags.cpp 19ae6c1c30a1054b64a9585f325bd0bf943af218 src/tests/cluster.cpp b04653af97d17aaa9d0d3ee872169b66cd67126b src/tests/mesos.cpp 07a64f0ff49a753ec26260cdf859d0584c3f935a Diff: https://reviews.apache.org/r/51958/diff/ Testing --- `make check` on OSX and Linux. Thanks, Neil Conway
