Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-19 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/#review149523
---


Ship it!




Ship It!

- Vinod Kone


On Sept. 19, 2016, 6:15 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51978/
> ---
> 
> (Updated Sept. 19, 2016, 6:15 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
> https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This refactoring was needed for better accomodating pod support
> for mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 525c89803ad1b29328420c5925a3e6045e487645 
> 
> Diff: https://reviews.apache.org/r/51978/diff/
> 
> 
> Testing
> ---
> 
> Manually Ran:
> mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
> --docker_image="ubuntu" --containerizer="docker"
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-19 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/#review149436
---


Fix it, then Ship it!




Ship It!


src/cli/execute.cpp (line 447)


kill this


- Guangya Liu


On 九月 19, 2016, 6:15 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51978/
> ---
> 
> (Updated 九月 19, 2016, 6:15 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
> https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This refactoring was needed for better accomodating pod support
> for mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 525c89803ad1b29328420c5925a3e6045e487645 
> 
> Diff: https://reviews.apache.org/r/51978/diff/
> 
> 
> Testing
> ---
> 
> Manually Ran:
> mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
> --docker_image="ubuntu" --containerizer="docker"
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-19 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/
---

(Updated Sept. 19, 2016, 6:14 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-6096
https://issues.apache.org/jira/browse/MESOS-6096


Repository: mesos


Description
---

This refactoring was needed for better accomodating pod support
for mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp 525c89803ad1b29328420c5925a3e6045e487645 

Diff: https://reviews.apache.org/r/51978/diff/


Testing
---

Manually Ran:
mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
--docker_image="ubuntu" --containerizer="docker"


Thanks,

Abhishek Dasgupta

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-18 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/#review149390
---




src/cli/execute.cpp (lines 526 - 538)


I like to simplify the logic as:

```
if (volumes.isSome()) {
  foreach (const Volume& volume, volumes.get()) {
containerInfo.add_volumes()->CopyFrom(volume);
  }
}
```



src/cli/execute.cpp (line 544)


```
volumes.isNone || volumes->empty()
```



src/cli/execute.cpp (line 778)


move this to L789


- Guangya Liu


On 九月 18, 2016, 9:06 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51978/
> ---
> 
> (Updated 九月 18, 2016, 9:06 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
> https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This refactoring was needed for better accomodating pod support
> for mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 525c89803ad1b29328420c5925a3e6045e487645 
> 
> Diff: https://reviews.apache.org/r/51978/diff/
> 
> 
> Testing
> ---
> 
> Manually Ran:
> mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
> --docker_image="ubuntu" --containerizer="docker"
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-18 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/
---

(Updated Sept. 18, 2016, 9:06 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-6096
https://issues.apache.org/jira/browse/MESOS-6096


Repository: mesos


Description (updated)
---

This refactoring was needed for better accomodating pod support
for mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp 525c89803ad1b29328420c5925a3e6045e487645 

Diff: https://reviews.apache.org/r/51978/diff/


Testing
---

Manually Ran:
mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
--docker_image="ubuntu" --containerizer="docker"


Thanks,

Abhishek Dasgupta

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-17 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/
---

(Updated Sept. 18, 2016, 5:16 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-6096
https://issues.apache.org/jira/browse/MESOS-6096


Repository: mesos


Description (updated)
---

Refactored commandScheduler in cli/execute.cpp to take TaskInfo.


Diffs (updated)
-

  src/cli/execute.cpp 525c89803ad1b29328420c5925a3e6045e487645 

Diff: https://reviews.apache.org/r/51978/diff/


Testing
---

Manually Ran:
mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
--docker_image="ubuntu" --containerizer="docker"


Thanks,

Abhishek Dasgupta

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-17 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/#review149351
---



A rebase is needed.


src/cli/execute.cpp (line 512)


Since you are doing a refactor, it is better to also set this parameter as 
`const Option& volumes` as the `volumes` is also an option 
value. With updating here, you may also want to update Line 764 as well.


- Guangya Liu


On 九月 17, 2016, 4:23 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51978/
> ---
> 
> (Updated 九月 17, 2016, 4:23 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
> https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This refactoring was needed for better accomodating pod support
> for mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 
> 
> Diff: https://reviews.apache.org/r/51978/diff/
> 
> 
> Testing
> ---
> 
> Manually Ran:
> mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
> --docker_image="ubuntu" --containerizer="docker"
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-17 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/#review149334
---


Ship it!




Ship It!

- Vinod Kone


On Sept. 17, 2016, 4:23 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51978/
> ---
> 
> (Updated Sept. 17, 2016, 4:23 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
> https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This refactoring was needed for better accomodating pod support
> for mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 
> 
> Diff: https://reviews.apache.org/r/51978/diff/
> 
> 
> Testing
> ---
> 
> Manually Ran:
> mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
> --docker_image="ubuntu" --containerizer="docker"
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-17 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/
---

(Updated Sept. 17, 2016, 4:23 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-6096
https://issues.apache.org/jira/browse/MESOS-6096


Repository: mesos


Description (updated)
---

This refactoring was needed for better accomodating pod support
for mesos-execute.


Diffs
-

  src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 

Diff: https://reviews.apache.org/r/51978/diff/


Testing
---

Manually Ran:
mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
--docker_image="ubuntu" --containerizer="docker"


Thanks,

Abhishek Dasgupta

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-17 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/
---

(Updated Sept. 17, 2016, 4:22 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-6096
https://issues.apache.org/jira/browse/MESOS-6096


Repository: mesos


Description (updated)
---

Refactored commandScheduler in cli/execute.cpp to take TaskInfo.


Diffs (updated)
-

  src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 

Diff: https://reviews.apache.org/r/51978/diff/


Testing (updated)
---

Manually Ran:
mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
--docker_image="ubuntu" --containerizer="docker"


Thanks,

Abhishek Dasgupta

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-17 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/#review149329
---



Bad patch!

Reviews applied: [51978]

Failed command: ./support/apply-review.sh -n -r 51978

Error:
2016-09-17 10:48:31 URL:https://reviews.apache.org/r/51978/diff/raw/ 
[13751/13751] -> "51978.patch" [1]
error: patch failed: src/cli/execute.cpp:355
error: src/cli/execute.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/15288/console

- Mesos ReviewBot


On Sept. 17, 2016, 6:38 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51978/
> ---
> 
> (Updated Sept. 17, 2016, 6:38 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
> https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This refactoring was needed for better accomodating pod support
> for mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 
> 
> Diff: https://reviews.apache.org/r/51978/diff/
> 
> 
> Testing
> ---
> 
> Manually Ran:
> mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
> --docker_image="ubuntu"
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-17 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/
---

(Updated Sept. 17, 2016, 6:38 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-6096
https://issues.apache.org/jira/browse/MESOS-6096


Repository: mesos


Description (updated)
---

This refactoring was needed for better accomodating pod support
for mesos-execute.


Diffs
-

  src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 

Diff: https://reviews.apache.org/r/51978/diff/


Testing
---

Manually Ran:
mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
--docker_image="ubuntu"


Thanks,

Abhishek Dasgupta

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

2016-09-17 Thread Abhishek Dasgupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51978/
---

(Updated Sept. 17, 2016, 6:37 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-6096
https://issues.apache.org/jira/browse/MESOS-6096


Repository: mesos


Description (updated)
---

Refactored commandScheduler in cli/execute.cpp to take TaskInfo.


Diffs (updated)
-

  src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 

Diff: https://reviews.apache.org/r/51978/diff/


Testing (updated)
---

Manually Ran:
mesos-execute --master=127.0.0.1:5050 --name="Hello1" --command="echo hello" 
--docker_image="ubuntu"


Thanks,

Abhishek Dasgupta