Re: Review Request 52005: Supported appc/runtime isolator to be nested aware.

2016-09-26 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52005/#review150523
---


Ship it!




Ship It!

- Jie Yu


On Sept. 27, 2016, 4:53 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52005/
> ---
> 
> (Updated Sept. 27, 2016, 4:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6192
> https://issues.apache.org/jira/browse/MESOS-6192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported appc/runtime isolator to be nested aware.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp 
> c25b0eeff44d66c2045fd8daf0feb8ea3db718e4 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp 
> a96298b801e8ef217dc0e88187b527e3c43a338e 
> 
> Diff: https://reviews.apache.org/r/52005/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 52005: Supported appc/runtime isolator to be nested aware.

2016-09-26 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52005/
---

(Updated Sept. 26, 2016, 9:53 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
Wu, Kevin Klues, and Vinod Kone.


Bugs: MESOS-6192
https://issues.apache.org/jira/browse/MESOS-6192


Repository: mesos


Description
---

Supported appc/runtime isolator to be nested aware.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/appc/runtime.hpp 
c25b0eeff44d66c2045fd8daf0feb8ea3db718e4 
  src/slave/containerizer/mesos/isolators/appc/runtime.cpp 
a96298b801e8ef217dc0e88187b527e3c43a338e 

Diff: https://reviews.apache.org/r/52005/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 52005: Supported appc/runtime isolator to be nested aware.

2016-09-26 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52005/#review150519
---




src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 135)


ALso nested container, right? Can you fix all?


- Jie Yu


On Sept. 27, 2016, 12:13 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52005/
> ---
> 
> (Updated Sept. 27, 2016, 12:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6192
> https://issues.apache.org/jira/browse/MESOS-6192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported appc/runtime isolator to be nested aware.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp 
> c25b0eeff44d66c2045fd8daf0feb8ea3db718e4 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp 
> a96298b801e8ef217dc0e88187b527e3c43a338e 
> 
> Diff: https://reviews.apache.org/r/52005/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 52005: Supported appc/runtime isolator to be nested aware.

2016-09-26 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52005/
---

(Updated Sept. 26, 2016, 5:13 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
Wu, Kevin Klues, and Vinod Kone.


Bugs: MESOS-6192
https://issues.apache.org/jira/browse/MESOS-6192


Repository: mesos


Description
---

Supported appc/runtime isolator to be nested aware.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/appc/runtime.hpp 
c25b0eeff44d66c2045fd8daf0feb8ea3db718e4 
  src/slave/containerizer/mesos/isolators/appc/runtime.cpp 
a96298b801e8ef217dc0e88187b527e3c43a338e 

Diff: https://reviews.apache.org/r/52005/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 52005: Supported appc/runtime isolator to be nested aware.

2016-09-18 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52005/#review149383
---




src/slave/containerizer/mesos/isolators/appc/runtime.cpp (lines 111 - 112)


Ditto on fixing all the comments in this file.



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 136)


What other cases?



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 202)


Ditto.


- Jie Yu


On Sept. 18, 2016, 5:30 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52005/
> ---
> 
> (Updated Sept. 18, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph 
> Wu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6192
> https://issues.apache.org/jira/browse/MESOS-6192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported appc/runtime isolator to be nested aware.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp 
> c25b0eeff44d66c2045fd8daf0feb8ea3db718e4 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp 
> a96298b801e8ef217dc0e88187b527e3c43a338e 
> 
> Diff: https://reviews.apache.org/r/52005/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>