Re: Review Request 52010: Supported filesystem linux isolator to be nested aware.

2016-09-28 Thread Jie Yu
> On Sept. 28, 2016, 8:11 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, lines 278-298 > > > > > > This is not correct, if we do that, we'll break Docker containerizer. > >

Re: Review Request 52010: Supported filesystem linux isolator to be nested aware.

2016-09-28 Thread Gilbert Song
> On Sept. 28, 2016, 1:11 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, lines 278-298 > > > > > > This is not correct, if we do that, we'll break Docker containerizer. > >

Re: Review Request 52010: Supported filesystem linux isolator to be nested aware.

2016-09-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52010/#review150753 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 52010: Supported filesystem linux isolator to be nested aware.

2016-09-27 Thread Gilbert Song
> On Sept. 18, 2016, 3:33 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, line 245 > > > > > > I think we can still call parseExecutorRunPath first. Then, we can call > >

Re: Review Request 52010: Supported filesystem linux isolator to be nested aware.

2016-09-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52010/ --- (Updated Sept. 27, 2016, 10:49 p.m.) Review request for mesos, Benjamin

Re: Review Request 52010: Supported filesystem linux isolator to be nested aware.

2016-09-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52010/#review149394 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 52010: Supported filesystem linux isolator to be nested aware.

2016-09-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52010/#review149386 --- Patch looks great! Reviews applied: [52003, 52004, 52005, 52006,