Re: Review Request 52037: Removed stout's `Set`.

2016-09-21 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52037/#review149809
---


Ship it!




Ship It!

- Michael Park


On Sept. 20, 2016, 4:05 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52037/
> ---
> 
> (Updated Sept. 20, 2016, 4:05 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-6159
> https://issues.apache.org/jira/browse/MESOS-6159
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed stout's `Set`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/Makefile.am fc2d2b20ec48b54b63f971c9887a492e61bb4a26 
>   3rdparty/stout/include/stout/set.hpp 
> bd7a9b9af51fc947cf105328843249e396f0282b 
>   3rdparty/stout/include/stout/stringify.hpp 
> b4d3e619d2a8fb346964771d9c1d8843a8c0f0b6 
>   3rdparty/stout/tests/CMakeLists.txt 
> f85dc998e8ba5f8d727933373c3e14500d0bdfae 
>   3rdparty/stout/tests/set_tests.cpp a271e99181785f6516f1adab465faa33fdc535f0 
> 
> Diff: https://reviews.apache.org/r/52037/diff/
> 
> 
> Testing
> ---
> 
> `make check` in various environments
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52037: Removed stout's `Set`.

2016-09-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52037/#review149713
---



Patch looks great!

Reviews applied: [52036, 52037]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 20, 2016, 4:05 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52037/
> ---
> 
> (Updated Sept. 20, 2016, 4:05 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-6159
> https://issues.apache.org/jira/browse/MESOS-6159
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed stout's `Set`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/Makefile.am fc2d2b20ec48b54b63f971c9887a492e61bb4a26 
>   3rdparty/stout/include/stout/set.hpp 
> bd7a9b9af51fc947cf105328843249e396f0282b 
>   3rdparty/stout/include/stout/stringify.hpp 
> b4d3e619d2a8fb346964771d9c1d8843a8c0f0b6 
>   3rdparty/stout/tests/CMakeLists.txt 
> f85dc998e8ba5f8d727933373c3e14500d0bdfae 
>   3rdparty/stout/tests/set_tests.cpp a271e99181785f6516f1adab465faa33fdc535f0 
> 
> Diff: https://reviews.apache.org/r/52037/diff/
> 
> 
> Testing
> ---
> 
> `make check` in various environments
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52037: Removed stout's `Set`.

2016-09-20 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52037/
---

(Updated Sept. 20, 2016, 6:05 p.m.)


Review request for mesos and Michael Park.


Changes
---

Reorganized patches by components.


Bugs: MESOS-6159
https://issues.apache.org/jira/browse/MESOS-6159


Repository: mesos


Description (updated)
---

Removed stout's `Set`.


Diffs (updated)
-

  3rdparty/stout/Makefile.am fc2d2b20ec48b54b63f971c9887a492e61bb4a26 
  3rdparty/stout/include/stout/set.hpp bd7a9b9af51fc947cf105328843249e396f0282b 
  3rdparty/stout/include/stout/stringify.hpp 
b4d3e619d2a8fb346964771d9c1d8843a8c0f0b6 
  3rdparty/stout/tests/CMakeLists.txt f85dc998e8ba5f8d727933373c3e14500d0bdfae 
  3rdparty/stout/tests/set_tests.cpp a271e99181785f6516f1adab465faa33fdc535f0 

Diff: https://reviews.apache.org/r/52037/diff/


Testing
---

`make check` in various environments


Thanks,

Benjamin Bannier