Re: Review Request 52064: Support for multiple versions of docs.

> On Feb. 24, 2018, 12:50 a.m., Benjamin Mahler wrote: > > Vinod and I went over this, a couple of issues: > > > > * The [endpoint > > documentation](http://mesos.apache.org/documentation/latest/endpoints/) is > > only being generated for latest (see > >

Re: Review Request 52064: Support for multiple versions of docs.

> On Feb. 24, 2018, 12:50 a.m., Benjamin Mahler wrote: > > Vinod and I went over this, a couple of issues: > > > > * The [endpoint > > documentation](http://mesos.apache.org/documentation/latest/endpoints/) is > > only being generated for latest (see > >

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review198236 --- Vinod and I went over this, a couple of issues: * The [endpoint

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review197432 --- Patch looks great! Reviews applied: [52064] Passed command:

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review197418 --- PASS: Mesos patch 52064 was successfully built and tested.

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated Feb. 13, 2018, 3:44 p.m.) Review request for mesos, haosdent huang

Re: Review Request 52064: Support for multiple versions of docs.

> On Feb. 9, 2018, 6:02 p.m., Benjamin Bannier wrote: > > I am wondering whether it wouldn't be simpler to have the site setup just > > generate output for the currently checked-out version and dump that into > > some version-specific output folder. We could then have some CI setup > >

Re: Review Request 52064: Support for multiple versions of docs.

> On Feb. 9, 2018, 6:02 p.m., Benjamin Bannier wrote: > > I am wondering whether it wouldn't be simpler to have the site setup just > > generate output for the currently checked-out version and dump that into > > some version-specific output folder. We could then have some CI setup > >

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review197173 --- I am wondering whether it wouldn't be simpler to have the site

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review197165 --- Bad patch! Reviews applied: [52064] Failed command: python

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review197144 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated Feb. 9, 2018, 1:46 a.m.) Review request for mesos, haosdent huang and

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review185249 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 52064: Support for multiple versions of docs.

Great. I'll be there too! On Tue, Sep 12, 2017 at 11:59 AM, Tim Anderegg wrote: > > > > On May 9, 2017, 4:30 p.m., haosdent huang wrote: > > > Hi, @tim Thanks a lot for your update. I am still reading you patch > and have not finished. Could return my comments if it

Re: Review Request 52064: Support for multiple versions of docs.

> On May 9, 2017, 4:30 p.m., haosdent huang wrote: > > Hi, @tim Thanks a lot for your update. I am still reading you patch and > > have not finished. Could return my comments if it works at my side. Thanks > > a lot for your contributions. > > Tim Anderegg wrote: > Thanks @haosdent,

Re: Review Request 52064: Support for multiple versions of docs.

> On May 9, 2017, 4:30 p.m., haosdent huang wrote: > > Hi, @tim Thanks a lot for your update. I am still reading you patch and > > have not finished. Could return my comments if it works at my side. Thanks > > a lot for your contributions. > > Tim Anderegg wrote: > Thanks @haosdent,

Re: Review Request 52064: Support for multiple versions of docs.

> On May 9, 2017, 4:30 p.m., haosdent huang wrote: > > Hi, @tim Thanks a lot for your update. I am still reading you patch and > > have not finished. Could return my comments if it works at my side. Thanks > > a lot for your contributions. Thanks @haosdent, please let me know if you have any

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review174335 --- Hi, @tim Thanks a lot for your update. I am still reading you

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review174121 --- Patch looks great! Reviews applied: [52064] Passed command:

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated May 5, 2017, 9:23 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated May 5, 2017, 9:20 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 52064: Support for multiple versions of docs.

> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote: > > site/Rakefile > > Lines 122 (patched) > > > > > > Replace all `\/latest\/` looks a bit dangerous. Do you have an example > > for this? > > Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated May 5, 2017, 9:16 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 52064: Support for multiple versions of docs.

> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote: > > Sorry for the long delay on this, I've finally carved up some time to try and close this out. I've left some comments below, and am working on addressing the issues, I will update the review tomorrow with the final result, hopefully

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated May 4, 2017, 9:26 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review167537 --- Closing this review due to inactivity. Please see our

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review160091 --- site/Rakefile (line 23)

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review158952 --- Patch looks great! Reviews applied: [52064] Passed command:

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated Dec. 12, 2016, 10:03 p.m.) Review request for mesos, haosdent huang

Re: Review Request 52064: Support for multiple versions of docs.

> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote: > > site/source/layouts/basic.erb, line 79 > > > > > > We need to make sure the style of verson selection here to match the > > breadcrumb above. > > > >

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review152043 --- what's the status of this? - Vinod Kone On Sept. 28, 2016,

Re: Review Request 52064: Support for multiple versions of docs.

> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote: > > site/source/layouts/documentation.erb, lines 15-19 > > > > > > Any reason that we add a back button instead of using the back button > > of browser? > > Tim

Re: Review Request 52064: Support for multiple versions of docs.

> On Sept. 28, 2016, 3:20 a.m., haosdent huang wrote: > > Get this error during build. > > > > ``` > > git version 2>&1:sh: git: command not found > > /mesos/site/Rakefile:4:in `' > > (See full trace by running task with --trace) > > rake aborted! > > git version 2>&1:sh: git: command not

Re: Review Request 52064: Support for multiple versions of docs.

> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote: > > site/Rakefile, lines 67-71 > > > > > > How about we only continue when tags in `["0.26.0", "0.26.."]`? This list of versions that don't have documentation in

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review150702 --- Patch looks great! Reviews applied: [52064] Passed command:

Re: Review Request 52064: Support for multiple versions of docs.

> On Sept. 28, 2016, 3:20 a.m., haosdent huang wrote: > > Get this error during build. > > > > ``` > > git version 2>&1:sh: git: command not found > > /mesos/site/Rakefile:4:in `' > > (See full trace by running task with --trace) > > rake aborted! > > git version 2>&1:sh: git: command not

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review150674 --- site/Rakefile (lines 35 - 39)

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review150673 --- Get this error during build. ``` git version 2>&1:sh: git:

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated Sept. 19, 2016, 8:43 p.m.) Review request for mesos and Vinod Kone.