Re: Review Request 52080: Ensured that `Latch*` in exec, sched drivers is initialized.

2016-09-20 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52080/#review149659
---


Ship it!




Ship It!

- Michael Park


On Sept. 20, 2016, 1:11 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52080/
> ---
> 
> (Updated Sept. 20, 2016, 1:11 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In error code paths, this value was previously left uninitialized, which
> might subsequently result in attempting to delete an uninitialized
> pointer value.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp c1cda5aca81dd8c73c50dd01ce49ef69805bbf09 
>   src/sched/sched.cpp 6a1a201202b8241e853a821ffcec49187a5bdf35 
> 
> Diff: https://reviews.apache.org/r/52080/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 52080: Ensured that `Latch*` in exec, sched drivers is initialized.

2016-09-20 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52080/
---

(Updated Sept. 20, 2016, 1:11 p.m.)


Review request for mesos and Michael Park.


Changes
---

Use a different approach.


Summary (updated)
-

Ensured that `Latch*` in exec, sched drivers is initialized.


Repository: mesos


Description (updated)
---

In error code paths, this value was previously left uninitialized, which
might subsequently result in attempting to delete an uninitialized
pointer value.


Diffs (updated)
-

  src/exec/exec.cpp c1cda5aca81dd8c73c50dd01ce49ef69805bbf09 
  src/sched/sched.cpp 6a1a201202b8241e853a821ffcec49187a5bdf35 

Diff: https://reviews.apache.org/r/52080/diff/


Testing
---

`make check` on OSX.


Thanks,

Neil Conway