----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52085/#review150002 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rukletsov On Sept. 22, 2016, 9:58 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52085/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2016, 9:58 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > Various simple-minded static analysis tools warn against using `strcpy` > when the `src` buffer is not a C string literal. Although the way in > which stout was using `strcpy` should have been safe, `memcpy` is a more > direct way to express what we want to do anyway. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/mktemp.hpp > 2e35c731aac9885024d64d9fd03c221e96ff3025 > 3rdparty/stout/include/stout/os/posix/mkdtemp.hpp > 31acbd406c7d447d6f141201c0cfa153d948ef9f > 3rdparty/stout/include/stout/os/raw/argv.hpp > 3ac62169be22eebaa56ec1a3b7cf1d0007b17870 > > Diff: https://reviews.apache.org/r/52085/diff/ > > > Testing > ------- > > `make check` on OSX and Linux. > > > Thanks, > > Neil Conway > >
