Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API.

2016-09-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52135/ --- (Updated Sept. 23, 2016, 7:48 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API.

2016-09-22 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52135/ --- (Updated Sept. 22, 2016, 7:49 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API.

2016-09-22 Thread Benjamin Mahler
> On Sept. 22, 2016, 5:23 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, lines 3235-3280 > > > > > > Hmm. I would put them in their own separate tests since the setup for > > them is easy enough. Sounds good

Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API.

2016-09-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52135/#review150029 --- Fix it, then Ship it! src/slave/http.cpp (line 1932)

Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API.

2016-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52135/#review149987 --- Patch looks great! Reviews applied: [52053, 52054, 52055, 52056,

Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API.

2016-09-21 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52135/ --- (Updated Sept. 22, 2016, 6:06 a.m.) Review request for mesos and Vinod Kone.