Re: Review Request 52658: Changed scheduler driver to send TASK_DROPPED.

2016-10-17 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52658/
---

(Updated Oct. 18, 2016, 1:01 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Tweak comment per review.


Bugs: MESOS-6331
https://issues.apache.org/jira/browse/MESOS-6331


Repository: mesos


Description
---

If a scheduler tries to launch a task when the scheduler driver is not
connected to the master, the scheduler driver creates a faux TASK_LOST
status update to indicate that the task launch has not succeeded. If the
framework is PARTITION_AWARE, the scheduler driver will now send
TASK_DROPPED instead.


Diffs (updated)
-

  src/sched/sched.cpp 9d1b5ce2e1a179b2e6ea212d99d8d7fe72a0793a 
  src/tests/fault_tolerance_tests.cpp 5a9944cf459ab688907d95bbda09f464b37efd1e 

Diff: https://reviews.apache.org/r/52658/diff/


Testing
---

`make check`


Thanks,

Neil Conway

Re: Review Request 52658: Changed scheduler driver to send TASK_DROPPED.

2016-10-17 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52658/#review152986
---


Fix it, then Ship it!





src/sched/sched.cpp (line 1305)


back ticks around `launchTasks`


- Vinod Kone


On Oct. 7, 2016, 11:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52658/
> ---
> 
> (Updated Oct. 7, 2016, 11:51 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6331
> https://issues.apache.org/jira/browse/MESOS-6331
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If a scheduler tries to launch a task when the scheduler driver is not
> connected to the master, the scheduler driver creates a faux TASK_LOST
> status update to indicate that the task launch has not succeeded. If the
> framework is PARTITION_AWARE, the scheduler driver will now send
> TASK_DROPPED instead.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 9d1b5ce2e1a179b2e6ea212d99d8d7fe72a0793a 
>   src/tests/fault_tolerance_tests.cpp 
> 5a9944cf459ab688907d95bbda09f464b37efd1e 
> 
> Diff: https://reviews.apache.org/r/52658/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>