Re: Review Request 52693: Changed master to send TASK_UNKNOWN during reconciliation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52693/#review153168 --- Ship it! Ship It! - Vinod Kone On Oct. 18, 2016, 1:14 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52693/ > --- > > (Updated Oct. 18, 2016, 1:14 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6330 > https://issues.apache.org/jira/browse/MESOS-6330 > > > Repository: mesos > > > Description > --- > > Previously, the master would send TASK_LOST in response to explicit > reconciliation requests for (a) unknown tasks at registered slaves and > (b) tasks at unknown slaves (neither registered nor unreachable). The > master will now send TASK_UNKNOWN for these situations if the framework > has the PARTITION_AWARE capability. > > > Diffs > - > > src/master/master.cpp 3c6b18ead44cd5f2978093f5415e974cfcbfa714 > src/tests/partition_tests.cpp 12fe8593ff17c35d540f944c428cf7f33b7dcbb3 > src/tests/reconciliation_tests.cpp 1412090299df388456f04ed58a1d384ce3ff550a > > Diff: https://reviews.apache.org/r/52693/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Neil Conway > >
Re: Review Request 52693: Changed master to send TASK_UNKNOWN during reconciliation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52693/ --- (Updated Oct. 18, 2016, 1:14 a.m.) Review request for mesos and Vinod Kone. Changes --- Rebase, new dep. Bugs: MESOS-6330 https://issues.apache.org/jira/browse/MESOS-6330 Repository: mesos Description --- Previously, the master would send TASK_LOST in response to explicit reconciliation requests for (a) unknown tasks at registered slaves and (b) tasks at unknown slaves (neither registered nor unreachable). The master will now send TASK_UNKNOWN for these situations if the framework has the PARTITION_AWARE capability. Diffs (updated) - src/master/master.cpp 3c6b18ead44cd5f2978093f5415e974cfcbfa714 src/tests/partition_tests.cpp 12fe8593ff17c35d540f944c428cf7f33b7dcbb3 src/tests/reconciliation_tests.cpp 1412090299df388456f04ed58a1d384ce3ff550a Diff: https://reviews.apache.org/r/52693/diff/ Testing --- `make check` Thanks, Neil Conway
Re: Review Request 52693: Changed master to send TASK_UNKNOWN during reconciliation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52693/ --- (Updated Oct. 13, 2016, 2:25 p.m.) Review request for mesos and Vinod Kone. Changes --- Tweak comment. Bugs: MESOS-6330 https://issues.apache.org/jira/browse/MESOS-6330 Repository: mesos Description --- Previously, the master would send TASK_LOST in response to explicit reconciliation requests for (a) unknown tasks at registered slaves and (b) tasks at unknown slaves (neither registered nor unreachable). The master will now send TASK_UNKNOWN for these situations if the framework has the PARTITION_AWARE capability. Diffs (updated) - src/master/master.cpp 7ef898781ce5c2349ffeaa3ce43e68dede19c852 src/tests/partition_tests.cpp 12fe8593ff17c35d540f944c428cf7f33b7dcbb3 src/tests/reconciliation_tests.cpp 1412090299df388456f04ed58a1d384ce3ff550a Diff: https://reviews.apache.org/r/52693/diff/ Testing --- `make check` Thanks, Neil Conway
Re: Review Request 52693: Changed master to send TASK_UNKNOWN during reconciliation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52693/#review152052 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418, 50422, 50699, 50700, 50701, 50702, 50703, 50704, 50705, 50706, 50707, 50844, 50845, 50846, 51020, 51371, 51374, 51375, 51376, 51377, 51021, 51706, 51653, 51707, 51805, 51845, 51891, 51909, 51913, 51953, 51954, 51955, 51956, 51957, 51958, 52039, 52083, 52656, 52657, 52658, 52659, 52693] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 10, 2016, 2:45 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52693/ > --- > > (Updated Oct. 10, 2016, 2:45 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6330 > https://issues.apache.org/jira/browse/MESOS-6330 > > > Repository: mesos > > > Description > --- > > Previously, the master would send TASK_LOST in response to explicit > reconciliation requests for (a) unknown tasks at registered slaves and > (b) tasks at unknown slaves (neither registered nor unreachable). The > master will now send TASK_UNKNOWN for these situations if the framework > has the PARTITION_AWARE capability. > > > Diffs > - > > src/master/master.cpp ad8993ae43e2508a3777f4062acaca1177ac77f2 > src/tests/partition_tests.cpp 12fe8593ff17c35d540f944c428cf7f33b7dcbb3 > src/tests/reconciliation_tests.cpp 1412090299df388456f04ed58a1d384ce3ff550a > > Diff: https://reviews.apache.org/r/52693/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Neil Conway > >
