Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/ --- (Updated Nov. 25, 2016, 11:49 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/#review156849 --- Ship it! Ship It! - Gastón Kleiman On Nov. 23, 2016, 12:30

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

> On Oct. 21, 2016, 7:35 p.m., Benjamin Mahler wrote: > > src/health-check/health_checker.cpp, line 188 > > > > > > Isn't this going to lead to some slightly confusing logging where we > > say "Rescheduling" for

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/ --- (Updated Nov. 23, 2016, 12:30 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/#review156284 --- Ship it! src/health-check/health_checker.hpp (line 122)

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

> On Oct. 21, 2016, 7:35 p.m., Benjamin Mahler wrote: > > src/health-check/health_checker.cpp, line 188 > > > > > > Isn't this going to lead to some slightly confusing logging where we > > say "Rescheduling" for

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/#review155937 --- Ship it! Ship It! - haosdent huang On Nov. 14, 2016, 10:35

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/ --- (Updated Nov. 14, 2016, 10:35 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/ --- (Updated Nov. 14, 2016, 10:28 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

> On Oct. 21, 2016, 7:35 p.m., Benjamin Mahler wrote: > > src/health-check/health_checker.cpp, line 188 > > > > > > Isn't this going to lead to some slightly confusing logging where we > > say "Rescheduling" for

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/#review153584 --- src/health-check/health_checker.cpp (line 187)

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

> On Oct. 17, 2016, 7:03 a.m., haosdent huang wrote: > > Is there any reason we try to avoid `check.interval_seconds()` in > > `reschedule`. Would be greate if could update the commit message about the > > motivation. > > haosdent huang wrote: > I feel it would be better to use

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

> On Oct. 17, 2016, 7:03 a.m., haosdent huang wrote: > > Is there any reason we try to avoid `check.interval_seconds()` in > > `reschedule`. Would be greate if could update the commit message about the > > motivation. I feel it would be better to use https://reviews.apache.org/r/52867/ as the

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/#review152829 --- Is there any reason we try to avoid `check.interval_seconds()` in

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/#review152671 --- Ship it! Ship It! - Gastón Kleiman On Oct. 14, 2016, 12:38