Re: Review Request 52906: Simplify the comparison logic for `ExecutorInfo`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52906/#review153165 --- Ship it! Ship It! - Vinod Kone On Oct. 15, 2016, 5:06 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52906/ > --- > > (Updated Oct. 15, 2016, 5:06 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6397 > https://issues.apache.org/jira/browse/MESOS-6397 > > > Repository: mesos > > > Description > --- > > This is a follow up fix of https://reviews.apache.org/r/52817/. > > > Diffs > - > > src/common/type_utils.cpp c6cf4f1d4acd040d21434221e5469ca911404a39 > > Diff: https://reviews.apache.org/r/52906/diff/ > > > Testing > --- > > ``` > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*TaskUsesExecutor*" > --verbose > sudo GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="*TaskGroupValidationTest.TaskUsesDifferentExecutor*" --verbose > ``` > > > Thanks, > > haosdent huang > >
Re: Review Request 52906: Simplify the comparison logic for `ExecutorInfo`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52906/#review152778 --- Patch looks great! Reviews applied: [52906] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 15, 2016, 5:06 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52906/ > --- > > (Updated Oct. 15, 2016, 5:06 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6397 > https://issues.apache.org/jira/browse/MESOS-6397 > > > Repository: mesos > > > Description > --- > > This is a follow up fix of https://reviews.apache.org/r/52817/. > > > Diffs > - > > src/common/type_utils.cpp c6cf4f1d4acd040d21434221e5469ca911404a39 > > Diff: https://reviews.apache.org/r/52906/diff/ > > > Testing > --- > > ``` > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*TaskUsesExecutor*" > --verbose > sudo GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="*TaskGroupValidationTest.TaskUsesDifferentExecutor*" --verbose > ``` > > > Thanks, > > haosdent huang > >
Re: Review Request 52906: Simplify the comparison logic for `ExecutorInfo`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52906/ --- (Updated Oct. 15, 2016, 5:06 a.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6397 https://issues.apache.org/jira/browse/MESOS-6397 Repository: mesos Description --- This is a follow up fix of https://reviews.apache.org/r/52817/. Diffs - src/common/type_utils.cpp c6cf4f1d4acd040d21434221e5469ca911404a39 Diff: https://reviews.apache.org/r/52906/diff/ Testing --- ``` sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*TaskUsesExecutor*" --verbose sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*TaskGroupValidationTest.TaskUsesDifferentExecutor*" --verbose ``` Thanks, haosdent huang
Re: Review Request 52906: Simplify the comparison logic for `ExecutorInfo`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52906/ --- (Updated Oct. 15, 2016, 5:04 a.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Summary (updated) - Simplify the comparison logic for `ExecutorInfo`. Bugs: MESOS-6283 https://issues.apache.org/jira/browse/MESOS-6283 Repository: mesos Description --- This is a follow up fix of https://reviews.apache.org/r/52817/. Diffs - src/common/type_utils.cpp c6cf4f1d4acd040d21434221e5469ca911404a39 Diff: https://reviews.apache.org/r/52906/diff/ Testing --- ``` sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*TaskUsesExecutor*" --verbose sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*TaskGroupValidationTest.TaskUsesDifferentExecutor*" --verbose ``` Thanks, haosdent huang
