Re: Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings.
> On March 12, 2017, 4:41 p.m., Kevin Klues wrote: > > @kaysoky Are you still ok shipping this? I can push it through myself if so. Yes, my first "Ship It!" still stands. You should be the one to push though. - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52944/#review168731 --- On March 12, 2017, 4:41 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52944/ > --- > > (Updated March 12, 2017, 4:41 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5676 > https://issues.apache.org/jira/browse/MESOS-5676 > > > Repository: mesos > > > Description > --- > > Updated CLI pylint configuration to disable 'fixme' warnings. > > > Diffs > - > > src/cli_new/pylint.config c398220db063d249e6c62cf7e8cd6757e7860630 > > > Diff: https://reviews.apache.org/r/52944/diff/2/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52944/#review168731 --- @kaysoky Are you still ok shipping this? I can push it through myself if so. - Kevin Klues On March 12, 2017, 11:41 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52944/ > --- > > (Updated March 12, 2017, 11:41 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5676 > https://issues.apache.org/jira/browse/MESOS-5676 > > > Repository: mesos > > > Description > --- > > Updated CLI pylint configuration to disable 'fixme' warnings. > > > Diffs > - > > src/cli_new/pylint.config c398220db063d249e6c62cf7e8cd6757e7860630 > > > Diff: https://reviews.apache.org/r/52944/diff/2/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52944/ --- (Updated March 12, 2017, 11:41 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5676 https://issues.apache.org/jira/browse/MESOS-5676 Repository: mesos Description --- Updated CLI pylint configuration to disable 'fixme' warnings. Diffs - src/cli_new/pylint.config c398220db063d249e6c62cf7e8cd6757e7860630 Diff: https://reviews.apache.org/r/52944/diff/2/ Testing --- Thanks, Kevin Klues
Re: Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52944/#review167409 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Oct. 20, 2016, 6:11 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52944/ > --- > > (Updated Oct. 20, 2016, 6:11 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5676 > https://issues.apache.org/jira/browse/MESOS-5676 > > > Repository: mesos > > > Description > --- > > Updated CLI pylint configuration to disable 'fixme' warnings. > > > Diffs > - > > src/cli_new/pylint.config c398220db063d249e6c62cf7e8cd6757e7860630 > > > Diff: https://reviews.apache.org/r/52944/diff/2/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52944/ --- (Updated Oct. 20, 2016, 6:11 p.m.) Review request for mesos and Joseph Wu. Changes --- Rebased Bugs: MESOS-5676 https://issues.apache.org/jira/browse/MESOS-5676 Repository: mesos Description --- Updated CLI pylint configuration to disable 'fixme' warnings. Diffs (updated) - src/cli_new/pylint.config c398220db063d249e6c62cf7e8cd6757e7860630 Diff: https://reviews.apache.org/r/52944/diff/ Testing --- Thanks, Kevin Klues
Re: Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52944/#review153009 --- Ship it! Considering how we love TODOs on our codebase, this one is perfectly reasonable to disable :) - Joseph Wu On Oct. 17, 2016, 1:11 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52944/ > --- > > (Updated Oct. 17, 2016, 1:11 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5676 > https://issues.apache.org/jira/browse/MESOS-5676 > > > Repository: mesos > > > Description > --- > > Updated CLI pylint configuration to disable 'fixme' warnings. > > > Diffs > - > > src/cli_new/pylint.config c398220db063d249e6c62cf7e8cd6757e7860630 > > Diff: https://reviews.apache.org/r/52944/diff/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
