Re: Review Request 52953: Added container 'exec' command to the CLI.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52953/#review167419
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Oct. 20, 2016, 6:13 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52953/
> ---
> 
> (Updated Oct. 20, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5676
> https://issues.apache.org/jira/browse/MESOS-5676
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added container 'exec' command to the CLI.
> 
> 
> Diffs
> -
> 
>   src/cli_new/lib/mesos/plugins/container/main.py PRE-CREATION 
>   src/cli_new/lib/mesos/plugins/container/tests.py PRE-CREATION 
>   src/cli_new/lib/mesos/tests/base.py PRE-CREATION 
>   src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 
>   src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf 
> 
> 
> Diff: https://reviews.apache.org/r/52953/diff/4/
> 
> 
> Testing
> ---
> 
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
> 
> (mesos-cli) $ sudo bin/mesos-cli-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 52953: Added container 'exec' command to the CLI.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52953/
---

(Updated Oct. 20, 2016, 6:13 p.m.)


Review request for mesos and Joseph Wu.


Changes
---

Rebased


Bugs: MESOS-5676
https://issues.apache.org/jira/browse/MESOS-5676


Repository: mesos


Description
---

Added container 'exec' command to the CLI.


Diffs (updated)
-

  src/cli_new/lib/mesos/plugins/container/main.py PRE-CREATION 
  src/cli_new/lib/mesos/plugins/container/tests.py PRE-CREATION 
  src/cli_new/lib/mesos/tests/base.py PRE-CREATION 
  src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 
  src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf 

Diff: https://reviews.apache.org/r/52953/diff/


Testing
---

$ cd src/cli_new
$ ./bootstrap
$ source activate

(mesos-cli) $ sudo bin/mesos-cli-tests


Thanks,

Kevin Klues

Re: Review Request 52953: Added container 'exec' command to the CLI.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52953/
---

(Updated Oct. 20, 2016, 5:26 p.m.)


Review request for mesos and Joseph Wu.


Changes
---

Updated to rename 'io' variable to something more descriptive.


Bugs: MESOS-5676
https://issues.apache.org/jira/browse/MESOS-5676


Repository: mesos


Description
---

Added container 'exec' command to the CLI.


Diffs (updated)
-

  src/cli_new/lib/mesos/plugins/container/main.py PRE-CREATION 
  src/cli_new/lib/mesos/plugins/container/tests.py PRE-CREATION 
  src/cli_new/lib/mesos/tests/base.py PRE-CREATION 
  src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 
  src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf 

Diff: https://reviews.apache.org/r/52953/diff/


Testing
---

$ cd src/cli_new
$ ./bootstrap
$ source activate

(mesos-cli) $ sudo bin/mesos-cli-tests


Thanks,

Kevin Klues

Re: Review Request 52953: Added container 'exec' command to the CLI.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52953/
---

(Updated Oct. 18, 2016, 7:01 p.m.)


Review request for mesos and Joseph Wu.


Changes
---

Updated to factor out the function of getting the proper mount namespace path.


Bugs: MESOS-5676
https://issues.apache.org/jira/browse/MESOS-5676


Repository: mesos


Description
---

Added container 'exec' command to the CLI.


Diffs (updated)
-

  src/cli_new/lib/mesos/plugins/container/main.py PRE-CREATION 
  src/cli_new/lib/mesos/plugins/container/tests.py PRE-CREATION 
  src/cli_new/lib/mesos/tests/base.py PRE-CREATION 
  src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 
  src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf 

Diff: https://reviews.apache.org/r/52953/diff/


Testing
---

$ cd src/cli_new
$ ./bootstrap
$ source activate

(mesos-cli) $ sudo bin/mesos-cli-tests


Thanks,

Kevin Klues

Re: Review Request 52953: Added container 'exec' command to the CLI.

[Kevin Klues]

> On Oct. 18, 2016, 1:01 a.m., Joseph Wu wrote:
> > src/cli_new/lib/mesos/plugins/container/main.py, line 30
> > 
> >
> > Hit the same linter-using-old-virtualenv error when applying this patch 
> > as described in:
> > https://reviews.apache.org/r/51008/#comment12

See comment in that one.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52953/#review153006
---


On Oct. 17, 2016, 8:12 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52953/
> ---
> 
> (Updated Oct. 17, 2016, 8:12 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5676
> https://issues.apache.org/jira/browse/MESOS-5676
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added container 'exec' command to the CLI.
> 
> 
> Diffs
> -
> 
>   src/cli_new/lib/mesos/plugins/container/main.py PRE-CREATION 
>   src/cli_new/lib/mesos/plugins/container/tests.py PRE-CREATION 
>   src/cli_new/lib/mesos/tests/base.py PRE-CREATION 
>   src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 
>   src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf 
> 
> Diff: https://reviews.apache.org/r/52953/diff/
> 
> 
> Testing
> ---
> 
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
> 
> (mesos-cli) $ sudo bin/mesos-cli-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 52953: Added container 'exec' command to the CLI.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52953/#review153006
---




src/cli_new/lib/mesos/plugins/container/main.py (line 30)


Hit the same linter-using-old-virtualenv error when applying this patch as 
described in:
https://reviews.apache.org/r/51008/#comment12


- Joseph Wu


On Oct. 17, 2016, 1:12 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52953/
> ---
> 
> (Updated Oct. 17, 2016, 1:12 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5676
> https://issues.apache.org/jira/browse/MESOS-5676
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added container 'exec' command to the CLI.
> 
> 
> Diffs
> -
> 
>   src/cli_new/lib/mesos/plugins/container/main.py PRE-CREATION 
>   src/cli_new/lib/mesos/plugins/container/tests.py PRE-CREATION 
>   src/cli_new/lib/mesos/tests/base.py PRE-CREATION 
>   src/cli_new/lib/mesos/util.py 87d2a65e78f04209566c1434b489b941d570ee01 
>   src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf 
> 
> Diff: https://reviews.apache.org/r/52953/diff/
> 
> 
> Testing
> ---
> 
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
> 
> (mesos-cli) $ sudo bin/mesos-cli-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>