Re: Review Request 52967: Improved documentation for shared persistent volumes.

2016-10-18 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52967/
---

(Updated Oct. 18, 2016, 4:15 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Try to address review comments.


Repository: mesos


Description
---

Improved documentation for shared persistent volumes.


Diffs (updated)
-

  docs/home.md 1c6b191bd194a9100ce1ad4bf5aff62a20ed8f41 
  docs/persistent-volume.md 5dfbbf1fb08cdf47f97ea6fb286e21ab26235d62 
  docs/shared-resources.md 29e43389c530f816118a32dcd7c2f1b82b0af431 

Diff: https://reviews.apache.org/r/52967/diff/


Testing
---

Previewed with site-docker.


Thanks,

Neil Conway



Re: Review Request 52967: Improved documentation for shared persistent volumes.

2016-10-18 Thread Neil Conway


> On Oct. 18, 2016, 7:19 a.m., Jiang Yan Xu wrote:
> > docs/home.md, line 54
> > 
> >
> > s/tasks/tasks across containers/ 
> > 
> > as multiple tasks sharing an executor today can already access the same 
> > non-shared persistent volume.

I changed this to say "between tasks managed by different executors on the same 
agent". Right now we mostly talk about "tasks" and "executors", so starting to 
talk about containers seems a bit inconsistent unless we're going to adopt that 
terminology more broadly (which might not be a bad idea).


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52967/#review153036
---


On Oct. 18, 2016, 12:50 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52967/
> ---
> 
> (Updated Oct. 18, 2016, 12:50 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved documentation for shared persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/home.md 1c6b191bd194a9100ce1ad4bf5aff62a20ed8f41 
>   docs/persistent-volume.md 5dfbbf1fb08cdf47f97ea6fb286e21ab26235d62 
>   docs/shared-resources.md 29e43389c530f816118a32dcd7c2f1b82b0af431 
> 
> Diff: https://reviews.apache.org/r/52967/diff/
> 
> 
> Testing
> ---
> 
> Previewed with site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 52967: Improved documentation for shared persistent volumes.

2016-10-18 Thread Jiang Yan Xu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52967/#review153036
---


Fix it, then Ship it!





docs/home.md (line 54)


s/tasks/tasks across containers/ 

as multiple tasks sharing an executor today can already access the same 
non-shared persistent volume.



docs/persistent-volume.md (line 35)


s/task/executor\/container/



docs/persistent-volume.md (line 39)


s/tasks/tasks in multiple contianers/?



docs/shared-resources.md (line 22)


s/a shared volume by// ?


- Jiang Yan Xu


On Oct. 17, 2016, 5:50 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52967/
> ---
> 
> (Updated Oct. 17, 2016, 5:50 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved documentation for shared persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/home.md 1c6b191bd194a9100ce1ad4bf5aff62a20ed8f41 
>   docs/persistent-volume.md 5dfbbf1fb08cdf47f97ea6fb286e21ab26235d62 
>   docs/shared-resources.md 29e43389c530f816118a32dcd7c2f1b82b0af431 
> 
> Diff: https://reviews.apache.org/r/52967/diff/
> 
> 
> Testing
> ---
> 
> Previewed with site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 52967: Improved documentation for shared persistent volumes.

2016-10-17 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52967/#review153026
---



Patch looks great!

Reviews applied: [52965, 52966, 52967]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 18, 2016, 12:50 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52967/
> ---
> 
> (Updated Oct. 18, 2016, 12:50 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved documentation for shared persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/home.md 1c6b191bd194a9100ce1ad4bf5aff62a20ed8f41 
>   docs/persistent-volume.md 5dfbbf1fb08cdf47f97ea6fb286e21ab26235d62 
>   docs/shared-resources.md 29e43389c530f816118a32dcd7c2f1b82b0af431 
> 
> Diff: https://reviews.apache.org/r/52967/diff/
> 
> 
> Testing
> ---
> 
> Previewed with site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>