Re: Review Request 54262: Added macOS 10.12 instructions to the getting started page.

2016-12-02 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54262/
---

(Updated Dec. 2, 2016, 8:18 p.m.)


Review request for mesos, Jie Yu and James Peach.


Changes
---

Removed the explicit `--with-apr` and `--with-svn` since we detect the brew 
installed headers automatically.

The issue was that we didn't have the apr detection on-par with the svn 
detection, Michael Park fixed it here:
https://reviews.apache.org/r/54280/


Repository: mesos


Description
---

There are several issues building on macOS 10.12 that should
be documented for users.


Diffs (updated)
-

  docs/getting-started.md 3c0fec6d15e0c2e5be85e9d482465b6008729ee0 

Diff: https://reviews.apache.org/r/54262/diff/


Testing
---

N/A


Thanks,

Benjamin Mahler

Re: Review Request 54262: Added macOS 10.12 instructions to the getting started page.

2016-12-02 Thread Benjamin Mahler 


> On Dec. 2, 2016, 5:51 p.m., James Peach wrote:
> > docs/getting-started.md, line 98
> > 
> >
> > I would do:
> > ```
> > --with-apr=$(brew --prefix apr)/libexec
> > --with-svn=$(brew --prefix subversion)
> > ```

It looks like with Michael's patches I probably just take the `--with-apr` and 
`--with-svn` out. It turns out we already look for brew's subversion when 
handling `--with-svn` but we didn't look for brew's subversion when handling 
`--with-apr`.

See: https://reviews.apache.org/r/54280/


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54262/#review157770
---


On Dec. 1, 2016, 8:49 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54262/
> ---
> 
> (Updated Dec. 1, 2016, 8:49 p.m.)
> 
> 
> Review request for mesos, Jie Yu and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There are several issues building on macOS 10.12 that should
> be documented for users.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 3c0fec6d15e0c2e5be85e9d482465b6008729ee0 
> 
> Diff: https://reviews.apache.org/r/54262/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 54262: Added macOS 10.12 instructions to the getting started page.

2016-12-02 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54262/#review157770
---




docs/getting-started.md (line 98)


I would do:
```
--with-apr=$(brew --prefix apr)/libexec
--with-svn=$(brew --prefix subversion)
```


- James Peach


On Dec. 1, 2016, 8:49 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54262/
> ---
> 
> (Updated Dec. 1, 2016, 8:49 p.m.)
> 
> 
> Review request for mesos, Jie Yu and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There are several issues building on macOS 10.12 that should
> be documented for users.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 3c0fec6d15e0c2e5be85e9d482465b6008729ee0 
> 
> Diff: https://reviews.apache.org/r/54262/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 54262: Added macOS 10.12 instructions to the getting started page.

2016-12-01 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54262/#review157668
---


Ship it!




Ship It!

- haosdent huang


On Dec. 1, 2016, 8:49 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54262/
> ---
> 
> (Updated Dec. 1, 2016, 8:49 p.m.)
> 
> 
> Review request for mesos, Jie Yu and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There are several issues building on macOS 10.12 that should
> be documented for users.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 3c0fec6d15e0c2e5be85e9d482465b6008729ee0 
> 
> Diff: https://reviews.apache.org/r/54262/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 54262: Added macOS 10.12 instructions to the getting started page.

2016-12-01 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54262/#review157658
---



Patch looks great!

Reviews applied: [54262]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Dec. 1, 2016, 8:49 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54262/
> ---
> 
> (Updated Dec. 1, 2016, 8:49 p.m.)
> 
> 
> Review request for mesos, Jie Yu and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There are several issues building on macOS 10.12 that should
> be documented for users.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 3c0fec6d15e0c2e5be85e9d482465b6008729ee0 
> 
> Diff: https://reviews.apache.org/r/54262/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>