Re: Review Request 55327: Windows: Fixed hanging symlink bug in `os::rmdir`.

2017-01-18 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55327/ --- (Updated Jan. 18, 2017, 8:50 p.m.) Review request for mesos, Andrew

Re: Review Request 55327: Windows: Fixed hanging symlink bug in `os::rmdir`.

2017-01-18 Thread Alex Clemmer
> On Jan. 18, 2017, 2:32 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/rmdir.hpp, lines 120-123 > > > > > > Note: This is actually unreachable. :| Embarrassing. - Alex

Re: Review Request 55327: Windows: Fixed hanging symlink bug in `os::rmdir`.

2017-01-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55327/#review162019 --- Ship it! 3rdparty/stout/include/stout/os/windows/rmdir.hpp

Re: Review Request 55327: Windows: Fixed hanging symlink bug in `os::rmdir`.

2017-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55327/ --- (Updated Jan. 15, 2017, 8:40 a.m.) Review request for mesos, Andrew

Re: Review Request 55327: Windows: Fixed hanging symlink bug in `os::rmdir`.

2017-01-09 Thread Lior Zeno
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55327/#review160930 --- 3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 97)