Re: Review Request 55449: Validate executor IDs in master validation.

2017-01-13 Thread Jiang Yan Xu 


> On Jan. 12, 2017, 4:31 p.m., Joseph Wu wrote:
> > src/tests/master_validation_tests.cpp, line 1751
> > 
> >
> > I had the impression that spaces in IDs were also bad...
> > 
> > I'm hoping we don't use the sandbox path in a shell anywhere anymore.

I agree but it's not one of the current rules. I am actually hoping to add a 
few more other rules (e.g., max length) but plan to do it separately so folks 
can discuss them. Here's it's checking against the current rules (which we 
unfortunately don't validate at all).


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55449/#review161467
---


On Jan. 12, 2017, 1:47 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55449/
> ---
> 
> (Updated Jan. 12, 2017, 1:47 a.m.)
> 
> 
> Review request for mesos, James Peach and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Validate executor IDs in master validation.
> 
> 
> Diffs
> -
> 
>   src/master/validation.hpp 57e81779ff7444904c2ad7bad33aaf9167b98d05 
>   src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f 
>   src/tests/master_validation_tests.cpp 
> e5d55e03648cb218d42adc594d6fa7d40ea9bcbb 
> 
> Diff: https://reviews.apache.org/r/55449/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55449: Validate executor IDs in master validation.

2017-01-12 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55449/#review161467
---




src/tests/master_validation_tests.cpp (line 1751)


I had the impression that spaces in IDs were also bad...

I'm hoping we don't use the sandbox path in a shell anywhere anymore.


- Joseph Wu


On Jan. 12, 2017, 1:47 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55449/
> ---
> 
> (Updated Jan. 12, 2017, 1:47 a.m.)
> 
> 
> Review request for mesos, James Peach and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Validate executor IDs in master validation.
> 
> 
> Diffs
> -
> 
>   src/master/validation.hpp 57e81779ff7444904c2ad7bad33aaf9167b98d05 
>   src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f 
>   src/tests/master_validation_tests.cpp 
> e5d55e03648cb218d42adc594d6fa7d40ea9bcbb 
> 
> Diff: https://reviews.apache.org/r/55449/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55449: Validate executor IDs in master validation.

2017-01-12 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55449/#review161428
---


Ship it!




Ship It!

- James Peach


On Jan. 12, 2017, 9:47 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55449/
> ---
> 
> (Updated Jan. 12, 2017, 9:47 a.m.)
> 
> 
> Review request for mesos, James Peach and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Validate executor IDs in master validation.
> 
> 
> Diffs
> -
> 
>   src/master/validation.hpp 57e81779ff7444904c2ad7bad33aaf9167b98d05 
>   src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f 
>   src/tests/master_validation_tests.cpp 
> e5d55e03648cb218d42adc594d6fa7d40ea9bcbb 
> 
> Diff: https://reviews.apache.org/r/55449/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>