Re: Review Request 56847: Removed unnecessary leveldb build rules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/#review166098 --- Ship it! I adjust to only build `libleveldb.a` ``` -all: $(SHARED_LIBS) $(SHARED_PROGRAMS) $(STATIC_OUTDIR)/libleveldb.a $(STATIC_OUTDIR)/libmemenv.a $(STATIC_PROGRAMS) +all: $(STATIC_OUTDIR)/libleveldb.a `` - haosdent huang On Feb. 20, 2017, 4:45 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56847/ > --- > > (Updated Feb. 20, 2017, 4:45 p.m.) > > > Review request for mesos and haosdent huang. > > > Bugs: MESOS-7146 > https://issues.apache.org/jira/browse/MESOS-7146 > > > Repository: mesos > > > Description > --- > > After upgraded to leveldb 1.19, the default CXXFLAGS of Mesos conflict > with the require flags when building `db/c_test.c` with clang in macOS. > This patch disables unnecessary rules in leveldb and bypass build > failures in macOS. > > > Diffs > - > > 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 > > Diff: https://reviews.apache.org/r/56847/diff/ > > > Testing > --- > > `make -j8` in macOS. > `make -j24 GTEST_FILTER="*"` in CentOS 7. > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 56847: Removed unnecessary leveldb build rules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- (Updated Feb. 20, 2017, 4:45 p.m.) Review request for mesos and haosdent huang. Bugs: MESOS-7146 https://issues.apache.org/jira/browse/MESOS-7146 Repository: mesos Description (updated) --- After upgraded to leveldb 1.19, the default CXXFLAGS of Mesos conflict with the require flags when building `db/c_test.c` with clang in macOS. This patch disables unnecessary rules in leveldb and bypass build failures in macOS. Diffs (updated) - 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 Diff: https://reviews.apache.org/r/56847/diff/ Testing (updated) --- `make -j8` in macOS. `make -j24 GTEST_FILTER="*"` in CentOS 7. Thanks, Tomasz Janiszewski
Re: Review Request 56847: Removed unnecessary leveldb build rules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- (Updated Feb. 20, 2017, 4:35 p.m.) Review request for mesos and haosdent huang. Bugs: MESOS-7146 https://issues.apache.org/jira/browse/MESOS-7146 Repository: mesos Description --- After upgraded to leveldb 1.19, the default CXXFLAGS of Mesos conflict with the require flags when building `db/c_test.c` with clang in macOS. This patch disables unnecessary rules in leveldb and bypass build failures in macOS. Diffs - 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 Diff: https://reviews.apache.org/r/56847/diff/ Testing --- Thanks, Tomasz Janiszewski
Re: Review Request 56847: Removed unnecessary leveldb build rules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56847/ --- (Updated Feb. 20, 2017, 4:33 p.m.) Review request for mesos and haosdent huang. Summary (updated) - Removed unnecessary leveldb build rules. Repository: mesos Description (updated) --- After upgraded to leveldb 1.19, the default CXXFLAGS of Mesos conflict with the require flags when building `db/c_test.c` with clang in macOS. This patch disables unnecessary rules in leveldb and bypass build failures in macOS. Diffs - 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 Diff: https://reviews.apache.org/r/56847/diff/ Testing --- Thanks, Tomasz Janiszewski
