Re: Review Request 56901: Updated master validation code to use the 'Principal' type.

2017-03-03 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56901/#review167895
---


Ship it!




Ship It!

- Vinod Kone


On March 3, 2017, 6:41 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56901/
> ---
> 
> (Updated March 3, 2017, 6:41 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates master validation code to
> make use of the `Principal` type instead of an
> `Option principal`.
> 
> 
> Diffs
> -
> 
>   src/master/validation.hpp 50a3e6ec6a6d44c9ad449edfbd5d2cf8540b3a73 
>   src/master/validation.cpp 41ef0d072ca53d9695c16b8dd98c319186f11f75 
> 
> 
> Diff: https://reviews.apache.org/r/56901/diff/4/
> 
> 
> Testing
> ---
> 
> Testing details can be found at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 56901: Updated master validation code to use the 'Principal' type.

2017-03-03 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56901/
---

(Updated March 3, 2017, 6:41 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till 
Toenshoff, and Vinod Kone.


Changes
---

Adjusted code for the `principal->value.isSome()` invariant.


Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003


Repository: mesos


Description
---

This patch updates master validation code to
make use of the `Principal` type instead of an
`Option principal`.


Diffs (updated)
-

  src/master/validation.hpp 50a3e6ec6a6d44c9ad449edfbd5d2cf8540b3a73 
  src/master/validation.cpp 41ef0d072ca53d9695c16b8dd98c319186f11f75 


Diff: https://reviews.apache.org/r/56901/diff/4/

Changes: https://reviews.apache.org/r/56901/diff/3-4/


Testing
---

Testing details can be found at the end of this review chain.


Thanks,

Greg Mann

Re: Review Request 56901: Updated master validation code to use the 'Principal' type.

2017-03-02 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56901/#review167591
---




src/master/validation.cpp
Lines 344 (patched)


Remove?


- Greg Mann


On Feb. 28, 2017, 6:30 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56901/
> ---
> 
> (Updated Feb. 28, 2017, 6:30 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates master validation code to
> make use of the `Principal` type instead of an
> `Option principal`.
> 
> 
> Diffs
> -
> 
>   src/master/validation.hpp f03b3280704083be1ca074ca07c69edbb49dae19 
>   src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f 
> 
> 
> Diff: https://reviews.apache.org/r/56901/diff/3/
> 
> 
> Testing
> ---
> 
> Testing details can be found at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 56901: Updated master validation code to use the 'Principal' type.

2017-02-27 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56901/
---

(Updated Feb. 28, 2017, 6:30 a.m.)


Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till 
Toenshoff, and Vinod Kone.


Changes
---

Changed 'AuthenticationContext' to 'Principal'.


Summary (updated)
-

Updated master validation code to use the 'Principal' type.


Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003


Repository: mesos


Description (updated)
---

This patch updates master validation code to
make use of the `Principal` type instead of an
`Option principal`.


Diffs (updated)
-

  src/master/validation.hpp f03b3280704083be1ca074ca07c69edbb49dae19 
  src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f 

Diff: https://reviews.apache.org/r/56901/diff/


Testing
---

Testing details can be found at the end of this review chain.


Thanks,

Greg Mann